Update generating-fsharp-types-from-dbml.md #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding " to the end of the dbml declaration so the following F# sharp code setting the connectionString doesn't look like it is a string.
|
One of our CI builds failed. I'll close and reopen this one to see if it fixes that. |
|
LGTM once build is green. Thanks, @jasonsnguyen! |
|
Open Publishing Build Service: The pull request content has been published and here are some changed files links of this time:
Status: Succeeded. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding closing "
Summary
When instantiating the DBML type provider, the ResolutionFolder static parameter is missing the closing ". A consequence of this is that the next line of code, which instantiates the connection string, looks like a string itself.