Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed issue where wording did not match code snippets #22211

Merged
merged 1 commit into from
Jan 7, 2021
Merged

Fixed issue where wording did not match code snippets #22211

merged 1 commit into from
Jan 7, 2021

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Jan 4, 2021 •
edited
Loading

Summary

Fixed issue where wording did not match code snippets

Fixes #22137

Preview

✔️ High-performance logging in .NET

@IEvangelist IEvangelist requested a review from a team as a code owner January 4, 2021 13:58
@IEvangelist IEvangelist added this to the January 2021 milestone Jan 6, 2021
BillWagner
BillWagner approved these changes Jan 7, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @IEvangelist You can :shipit: when ready.

@IEvangelist IEvangelist merged commit cc261a2 into dotnet:master Jan 7, 2021
@IEvangelist IEvangelist deleted the high-perf-logging branch January 7, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
January 2021
Development

Successfully merging this pull request may close these issues.

Wrong example code and descriptions in "High-performance logging in .NET"
2 participants
@IEvangelist @BillWagner