Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update feedback url for ILxxxx analyzers #22348

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Conversation

@Youssef1313 Youssef1313 requested a review from a team as a code owner January 13, 2021 12:55
@dotnet-bot dotnet-bot added this to the January 2021 milestone Jan 13, 2021
Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this. Should we be more specific about the ca* prefix then too? Or just leave it as a catch all for all other files.

@@ -159,6 +159,7 @@
"docs/azure/sdk/**/*.*": "https://github.com/azure/azure-sdk-for-net",
"docs/fsharp/**/**.md": "https://github.com/dotnet/fsharp",
"docs/fundamentals/code-analysis/quality-rules/**/*.md": "https://github.com/dotnet/roslyn-analyzers/issues",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"docs/fundamentals/code-analysis/quality-rules/**/*.md": "https://github.com/dotnet/roslyn-analyzers/issues",
"docs/fundamentals/code-analysis/quality-rules/**/ca*.md": "https://github.com/dotnet/roslyn-analyzers/issues",

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd leave it to catch other pages (e.g. index and category overview pages)

@gewarren gewarren merged commit 0c9ef2e into dotnet:master Jan 13, 2021
@Youssef1313 Youssef1313 deleted the patch-17 branch January 13, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants