Add help link for IL3000 and IL3001 #1736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging @gewarren who is the doc owner for analyzer rules shipping in the .NET SDK |
|
So even though the analyzers are arriving via the linker repo, they still ship with the SDK? If so, I think we should just leave the docs as is? "Moving forward, the analyzer will be packed and flown to the SDK via the linker repo (see dotnet/sdk#15239)." |
This is correct. |
|
Yup, I'd leave the docs where they are. Change LGTM. |
agocke
pushed a commit
to dotnet/runtime
that referenced
this pull request
Nov 16, 2022
Commit migrated from dotnet/linker@1d02cb5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules had a help link when they were in roslyn-analyzers repository (see dotnet/roslyn-analyzers#4680), but the help link was lost after porting it here.
This PR adds the help link back.
Tagging @mavasani in case he wants the documentation to be ported from dotnet/docs to somewhere else.