Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete orphans and fix build suggestions #34146

Merged
merged 13 commits into from
Feb 28, 2023
Merged

Conversation

gewarren
Copy link
Contributor

Fixes #33658

@gewarren
Copy link
Contributor Author

The snippets 5000 error is strange. Is it an error on my side, or did something change recently with Snippets 5000? @adegeo @IEvangelist

@gewarren gewarren marked this pull request as ready for review February 17, 2023 02:36
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

I'm also really confused by the exceptions in the Snippets 5000. We haven't updated the package in our repo in a while. That stack trace isn't part of the .NET executable. @adegeo Is it coming from a package in the powershell script?

@IEvangelist
Copy link
Member

Hi @BillWagner and @gewarren - the errors are simply being reported by the PowerShell script, see these lines:

Write-Host "Total errors: $count"

foreach ($er in $errors) {

# ...

In the Get-MSBuildResults.ps1 there are three places where System.IO.Path.Combine are called, and these automation stack traces look reminiscent of that of PowerShell.

It's claiming that path1 is null, which is possible here https://github.com/dotnet/docs/blob/main/.github/workflows/dependencies/Get-MSBuildResults.ps1#L150.

Total errors: 32
Error: ERROR: System.Management.Automation.MethodInvocationException: Exception calling "Combine" with "2" argument(s): "Value cannot be null. (Parameter 'path1')"
 ---> System.ArgumentNullException: Value cannot be null. (Parameter 'path1')
   at System.IO.Path.Combine(String path1, String path2)

I think this could be prevented with a guard there, but we'll have to verify with @adegeo.

@gewarren
Copy link
Contributor Author

The Snippets 5000 errors are expected. Quoted from how-to-run-a-workflow.md:

    > [!NOTE]
    > Please replace `Workflow1` in these examples with `FlowchartNumberGuessWorkflow`, `SequentialNumberGuessWorkflow`, or `StateMachineNumberGuessWorkflow`, depending on which workflow you completed in the previous [How to: Create a Workflow](how-to-create-a-workflow.md) step. If you do not replace `Workflow1` then you will get build errors when you try and build or run the workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repo chores - Feb 2023
4 participants