Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: LocateProjects doesn't correctly handle project deletions. #145

Closed
IEvangelist opened this issue Mar 7, 2023 · 1 comment · Fixed by #238
Closed

[Bug]: LocateProjects doesn't correctly handle project deletions. #145

IEvangelist opened this issue Mar 7, 2023 · 1 comment · Fixed by #238
Assignees
Labels
bug Something isn't working 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@IEvangelist
Copy link
Member

IEvangelist commented Mar 7, 2023

Discovery

I was investigating why four recent dependabot automated PRs were failing. Here is an example failed build from one of the: https://github.com/dotnet/docs/actions/runs/4355198732/jobs/7611491747.

I immediately found it odd that there were missing source code files. I discovered that these files and projects were deleted.

Realization

The LocateProjects app needs to account for project deletions.

Recently, there was a significant deletion PR in docs: dotnet/docs#34146. This PR deleted several projects that were part of a solution. However, the snippets 5000 build validation didn't validate that the solution still compiled because the solution (*.sln) wasn't returned as part of the LocateProjects subroutine.

In other words, LocateProjects needs to be updated to return solutions when a project is deleted.

Proposal

When a project is deleted, check to see if the said project was part of a solution. If it was, return the solution that it was a part of.


Associated WorkItem - 85827

@adegeo
Copy link
Contributor

adegeo commented Apr 3, 2023

Will handle as part of #113

I've written a test case for the code base where this fails to pass. As I upgrade the tool I can validate that the test case passes and we'll know this scenario is covered.

@adegeo adegeo self-assigned this Apr 3, 2023
@adegeo adegeo added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Apr 18, 2023
@github-actions github-actions bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Apr 19, 2023
@adegeo adegeo closed this as completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants