You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I immediately found it odd that there were missing source code files. I discovered that these files and projects were deleted.
Realization
The LocateProjects app needs to account for project deletions.
Recently, there was a significant deletion PR in docs: dotnet/docs#34146. This PR deleted several projects that were part of a solution. However, the snippets 5000 build validation didn't validate that the solution still compiled because the solution (*.sln) wasn't returned as part of the LocateProjects subroutine.
In other words, LocateProjects needs to be updated to return solutions when a project is deleted.
Proposal
When a project is deleted, check to see if the said project was part of a solution. If it was, return the solution that it was a part of.
I've written a test case for the code base where this fails to pass. As I upgrade the tool I can validate that the test case passes and we'll know this scenario is covered.
Discovery
I was investigating why four recent dependabot automated PRs were failing. Here is an example failed build from one of the: https://github.com/dotnet/docs/actions/runs/4355198732/jobs/7611491747.
I immediately found it odd that there were missing source code files. I discovered that these files and projects were deleted.
Realization
The LocateProjects app needs to account for project deletions.
Recently, there was a significant deletion PR in docs: dotnet/docs#34146. This PR deleted several projects that were part of a solution. However, the snippets 5000 build validation didn't validate that the solution still compiled because the solution (*.sln) wasn't returned as part of the LocateProjects subroutine.
In other words, LocateProjects needs to be updated to return solutions when a project is deleted.
Proposal
When a project is deleted, check to see if the said project was part of a solution. If it was, return the solution that it was a part of.
Associated WorkItem - 85827
The text was updated successfully, but these errors were encountered: