Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for CA1865/CA1866/CA1867 #36417

Merged
merged 9 commits into from Jul 31, 2023

Conversation

@mrahhal mrahhal requested review from adegeo, gewarren and a team as code owners July 27, 2023 10:21
@dotnet-bot dotnet-bot added this to the July 2023 milestone Jul 27, 2023
@ghost ghost added the community-contribution Indicates PR is created by someone from the .NET community. label Jul 27, 2023
@mrahhal
Copy link
Contributor Author

mrahhal commented Jul 27, 2023

Didn't know multiple rules can be put in the same file, as in the case of syslib1040-1049. Should these three rules similarly be in the same file?

@gewarren
Copy link
Contributor

@mrahhal Yes I think it's better to put these in one file. You'll also need to add redirections similar to:

"source_path_from_root": "/docs/fundamentals/syslib-diagnostics/syslib1040.md",
"redirect_url": "/dotnet/fundamentals/syslib-diagnostics/syslib1040-1049"
},
{
"source_path_from_root": "/docs/fundamentals/syslib-diagnostics/syslib1041.md",
"redirect_url": "/dotnet/fundamentals/syslib-diagnostics/syslib1040-1049"
},
{
"source_path_from_root": "/docs/fundamentals/syslib-diagnostics/syslib1042.md",
"redirect_url": "/dotnet/fundamentals/syslib-diagnostics/syslib1040-1049"

@gewarren gewarren merged commit 197f228 into dotnet:main Jul 31, 2023
8 checks passed
@mrahhal mrahhal deleted the use-string-method-char-overload branch July 31, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants