New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UseStringMethodCharOverloadWithSingleCharacters analyzer and fixer #6799
Add UseStringMethodCharOverloadWithSingleCharacters analyzer and fixer #6799
Conversation
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6799 +/- ##
========================================
Coverage 96.34% 96.34%
========================================
Files 1386 1394 +8
Lines 326229 327150 +921
Branches 10729 10768 +39
========================================
+ Hits 314296 315206 +910
- Misses 9225 9230 +5
- Partials 2708 2714 +6 |
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Show resolved
Hide resolved
...NetCore.Analyzers/Performance/CSharpUseStringMethodCharOverloadWithSingleCharacters.Fixer.cs
Outdated
Show resolved
Hide resolved
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
@mrahhal let's know when you finish all coding so we can review it in one shot. Thanks! |
@tarekgh Resolved all the pending conversations (except for the severity thing). Ready for another round of review. |
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
src/NetAnalyzers/Core/Microsoft.NetCore.Analyzers/xlf/MicrosoftNetCoreAnalyzersResources.ko.xlf
Outdated
Show resolved
Hide resolved
@Youssef1313 @buyaa-n it looks you are already reviewing the PR. Thanks for that. I finished reviewing and LGTM. Please let me know if you have any more comments here. @stephentoub do you want to take a quick look? CC @carlossanlop as you have added some analyzer and may have any comment. |
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
...e/Microsoft.NetCore.Analyzers/Performance/UseStringMethodCharOverloadWithSingleCharacters.cs
Outdated
Show resolved
Hide resolved
Thanks @mrahhal for helping implementing it. Are you interested in playing more with the analyzers? dotnet/runtime#78406 is a good one you may consider if you are interested and if @Youssef1313 not doing it :-) |
Thanks for the reviews. Yes I'm planning to look at more from the table. Working on the docs PR for this, will post here. |
Docs PR: dotnet/docs#36417 |
Resolves dotnet/runtime#78392
cc @tarekgh @Youssef1313 @stephentoub