-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Collection expressions to the language reference #36782
Merged
BillWagner
merged 13 commits into
dotnet:main
from
BillWagner:collection-expression-reference
Aug 31, 2023
Merged
Add Collection expressions to the language reference #36782
BillWagner
merged 13 commits into
dotnet:main
from
BillWagner:collection-expression-reference
Aug 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillWagner
force-pushed
the
collection-expression-reference
branch
5 times, most recently
from
August 25, 2023 14:50
f178a79
to
3067d01
Compare
pkulikov
reviewed
Aug 28, 2023
docs/csharp/language-reference/builtin-types/collection-expressions.md
Outdated
Show resolved
Hide resolved
BillWagner
requested review from
IEvangelist,
gewarren and
a team
as code owners
August 28, 2023 20:13
gewarren
approved these changes
Aug 31, 2023
Move programming guide articles on arrays and collections into the language reference section. This set of content will be updated and edited, then collection expressions will be added.
Move all array content into the language reference.
Move snippets to the language reference location.
Run cleanrepo to update redirected links with the new target, and replace absolute links with relative links.
Fix open issues on the collection articles, and perform an edit pass to update. Simplify examples and remove outdated examples. Update text. Instead of listing all collections, refer to articles in the .NET fundamentals and API reference where all collections are listed.
Edit and update the Arrays article. Remove older outdated samples, update style (both text and code), and fix two open issues: - Fix dotnet#27181 Clarify the default value for array elements. - Fix dotnet#29181 Clarify the row, column for a 2D array.
Do a grammar check on the new article, fix build warnings, and add links.
The language reference and spec titles were duplicated
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
BillWagner
force-pushed
the
collection-expression-reference
branch
from
August 31, 2023 19:20
91da92a
to
67afb33
Compare
Move snippets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #36356
This PR has the tasks from the #36356 (comment)
Reorganize some of the content: Move the collections and arrays content from the programming guide to the language reference. Consolidate the articles on arrays into a single article. Then update the consolidated article by moving snippets and updating the samples.
Fix existing issues: Edit pass on collections article. Simplify examples and remove outdated examples. Update text. Instead of listing all collections, refer to articles in the .NET fundamentals and API reference where all collections are listed.
Fixes #20541: Don't list all collection types. That's brittle. Instead, refer to locations in the standard section, and the API reference where all collections can be found for the current version.
Edit pass on arrays article. Simplify and combine many of the samples. Update the related text. Update the samples and the text to match our current style.
Fixes #27181: Rewrite the text that describes the default value for any array elements.
Fixes #29181: Specify that 2 D arrays can be thought of as
[row, column]
.Add collection expressions article: This is the new article that covers collection expressions.
Internal previews for significant changes:
Other files changed are for updated links.
Internal previews
Toggle expand/collapse
for
,foreach
,do
, andwhile