Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ENV variable for app user ID #4508

Merged
merged 7 commits into from
Mar 27, 2023
Merged

Conversation

lbussell
Copy link
Contributor

Fixes #4506

@mthalman, are the changes to the 6.0/7.0 CBL Mariner distroless images appropriate? They can be reversed if we don't want to add anything new and potentially breaking there.

Copy link
Member

@mthalman mthalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update the unit tests to validate the new environment variable.

@mthalman
Copy link
Member

@mthalman, are the changes to the 6.0/7.0 CBL Mariner distroless images appropriate?

I originally didn't think this was going to be a breaking change. But after seeing that the VerifyDefaultUser test is failing, I realize now that it is technically a breaking change because it is changing the value of the User in the image metadata. So I think we should exclude Mariner distroless from these changes.

@richlander
Copy link
Member

I was also wondering that, about Mariner 6/7. I agree. Let's got with .NET 8.

Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor suggestion, rest looks good.

tests/Microsoft.DotNet.Docker.Tests/ProductImageData.cs Outdated Show resolved Hide resolved
@lbussell lbussell merged commit 5c63e8d into dotnet:nightly Mar 27, 2023
lbussell added a commit to lbussell/dotnet-docker that referenced this pull request Apr 10, 2023
richlander pushed a commit to richlander/dotnet-docker that referenced this pull request Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants