Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: convert tests that dont use AssertQuery to use the pattern #12501

Closed
maumar opened this issue Jun 29, 2018 · 1 comment
Closed

Query: convert tests that dont use AssertQuery to use the pattern #12501

maumar opened this issue Jun 29, 2018 · 1 comment
Assignees
@maumar
Labels
closed-duplicate

Comments

@maumar
Copy link
Contributor

maumar commented Jun 29, 2018

Some query tests don't use AssertQuery pattern for verification. We should convert them to the pattern. Reason is that we get full result verification for the test and async execution for free.
@maumar maumar self-assigned this Jun 29, 2018
@ajcvickers ajcvickers added this to the Backlog milestone Jun 29, 2018
@ajcvickers ajcvickers modified the milestones: Backlog, 3.1.0 Sep 4, 2019
maumar added a commit that referenced this issue Oct 2, 2019
@maumar
Miscellaneous query test fixes
3d664fd 
resolves #14550
resolves #15164
resolves #15994

added regression tests for #14671
added regression test for #17852
converted remaining tests in Gears of War into AssertQuery pattern (part of #12501)
@maumar maumar mentioned this issue Oct 2, 2019
Merged
maumar added a commit that referenced this issue Oct 2, 2019
@maumar
Miscellaneous query test fixes
81c1411 
resolves #14550
resolves #15164
resolves #15994

added regression tests for #14671
added regression test for #17852
converted remaining tests in Gears of War into AssertQuery pattern (part of #12501)
maumar added a commit that referenced this issue Oct 2, 2019
@maumar
Miscellaneous query test fixes
1bd4e85 
resolves #14550
resolves #15164
resolves #15994
resolves #16722

added regression tests for #14671
added regression test for #17852
converted remaining tests in Gears of War into AssertQuery pattern (part of #12501)
@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 11, 2019
@AndriySvyryd
Copy link
Member

Duplicate of #21393

@AndriySvyryd AndriySvyryd marked this as a duplicate of #21393 Sep 5, 2020
@ajcvickers ajcvickers removed this from the Backlog milestone Sep 11, 2020
@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
closed-duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ajcvickers @smitpatel @maumar @AndriySvyryd