Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query: investigate suspicious SQL generated by query tests #15994

Closed
maumar opened this issue Jun 7, 2019 · 2 comments · Fixed by #18193 or #18803
Closed

Query: investigate suspicious SQL generated by query tests #15994

maumar opened this issue Jun 7, 2019 · 2 comments · Fixed by #18193 or #18803
Assignees
@maumar
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Milestone
5.0.0

Comments

@maumar
Copy link
Contributor

maumar commented Jun 7, 2019

With new query pipeline sufficiently advanced, we can enable SQL verification. This issue is to track any "suspicious" results.
@ajcvickers ajcvickers added this to the 3.0.0 milestone Jun 10, 2019
@smitpatel
Copy link
Member

Include_reference_on_derived_type_using_lambda_with_soft_cast

@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jun 28, 2019
@smitpatel smitpatel removed this from the Backlog milestone Sep 12, 2019
@smitpatel smitpatel added this to the 3.1.0 milestone Sep 20, 2019
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 2, 2019
maumar added a commit that referenced this issue Oct 2, 2019
@maumar
Miscellaneous query test fixes
3d664fd 
resolves #14550
resolves #15164
resolves #15994

added regression tests for #14671
added regression test for #17852
converted remaining tests in Gears of War into AssertQuery pattern (part of #12501)
@maumar maumar mentioned this issue Oct 2, 2019
Merged
maumar added a commit that referenced this issue Oct 2, 2019
@maumar
Miscellaneous query test fixes
81c1411 
resolves #14550
resolves #15164
resolves #15994

added regression tests for #14671
added regression test for #17852
converted remaining tests in Gears of War into AssertQuery pattern (part of #12501)
@maumar maumar closed this as completed in 1bd4e85 Oct 3, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0, 3.1.0-preview2 Oct 24, 2019
@maumar
Copy link
Contributor Author

maumar commented Nov 1, 2019

there are still sql asserts disabled with this issue, re-opening

@maumar maumar reopened this Nov 1, 2019
@maumar maumar modified the milestones: 3.1.0-preview2, Backlog Nov 1, 2019
@maumar maumar removed the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 1, 2019
maumar added a commit that referenced this issue Nov 7, 2019
@maumar
Fix to #15994 - Query: investigate suspicious SQL generated by query …
8efb229 
…tests

Many tests are not producing expected SQL, tracked remaining ones with relevant issues.

Resolves #15994
@maumar maumar mentioned this issue Nov 7, 2019
Merged
maumar added a commit that referenced this issue Nov 7, 2019
@maumar
Fix to #15994 - Query: investigate suspicious SQL generated by query …
c68a422 
…tests

Many tests are not producing expected SQL, tracked remaining ones with relevant issues.

Resolves #15994
@maumar maumar modified the milestones: Backlog, 5.0.0 Nov 7, 2019
@maumar maumar added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Nov 7, 2019
maumar added a commit that referenced this issue Nov 12, 2019
@maumar
Fix to #15994 - Query: investigate suspicious SQL generated by query …
477d196 
…tests

Many tests are not producing expected SQL, tracked remaining ones with relevant issues.

Resolves #15994
@maumar maumar closed this as completed in deac068 Nov 12, 2019
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-preview1 Mar 13, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-preview1, 5.0.0 Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maumar maumar

Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-3.0 type-bug
Projects
None yet
Milestone
5.0.0
3 participants
@ajcvickers @smitpatel @maumar