Unstable sort for Correlated_collection_with_top_level_FirstOrDefault test

[cincuranet]

The test Correlated_collection_with_top_level_FirstOrDefault does not have an explicit unique sort and hence the loop will trigger false negative when the order is different.

To be precise, the query returns 2 rows with IDs 7 and 8. And the order isn't defined because the Nickname, SquadId and FullName are same (i.e. here).

[ajcvickers]

@cincuranet Can you submit a PR to fix this?

[cincuranet]

I can. But I have my own work to do, so it's going to take a while.

[j-rewerts]

I'm open to handling this. I just want to make sure @cincuranet hasn't started on it yet.

[cincuranet]

Go for it.

[j-rewerts]

@cincuranet Which version of EF Core are you using?

[j-rewerts]

It looks like this test is related to #15043 . Digging deeper, it looks like this test was disabled for the query rewrite effort. @maumar Would it be best for me to hold off on this until work is further along?

[maumar]

@j-rewerts we can take the PR now. The test has been disabled preemptively, as the first phase of query rewrite changes will break it, but for now the scenario works. You can enable the test on your box to make sure the fix is correct and disable it back for the PR. Once #15043 is fixed we can get the test online and it will have the proper fix already.