Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microsoft.Data.Sqlite: Use Span overload of sqlite3_prepare_v2 #16202

Closed
Tracked by #22949
bricelam opened this issue Jun 21, 2019 · 1 comment · Fixed by #24331
Closed
Tracked by #22949

Microsoft.Data.Sqlite: Use Span overload of sqlite3_prepare_v2 #16202

bricelam opened this issue Jun 21, 2019 · 1 comment · Fixed by #24331
Assignees
@bricelam
Labels
area-adonet-sqlite area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@bricelam
Copy link
Contributor

bricelam commented Jun 21, 2019 •
edited

This will avoid unnecessary UTF-8 conversions and copying on commands with multiple statements (aka batches).

I took a stab at this while updating SQLitePCL.raw to 2.0.0, but hit the compiler error "ReadOnlySpan<byte> cannot be used inside iteration blocks" 🤷‍♂️
@bricelam bricelam mentioned this issue Jun 22, 2019
Merged
@ajcvickers ajcvickers added this to the Backlog milestone Jun 24, 2019
@ajcvickers ajcvickers mentioned this issue Oct 10, 2020
Open
16 tasks
bricelam added a commit to bricelam/efcore that referenced this issue Mar 5, 2021
@bricelam
Microsoft.Data.Sqlite: Use Span overload of sqlite3_prepare
0968a63 
Removes a lot of unnecessary allocations and conversions from utf8

Fixes dotnet#16202
@bricelam bricelam mentioned this issue Mar 5, 2021
Merged
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Mar 5, 2021
@bricelam bricelam modified the milestones: Backlog, 6.0.0 Mar 5, 2021
@bricelam bricelam modified the milestones: 6.0.0, 6.0.0-preview3 Mar 9, 2021
@bricelam bricelam mentioned this issue Aug 13, 2021
Merged
@bricelam
Copy link
Contributor Author

Re-opening since we had to revert this due to ericsink/SQLitePCL.raw#430

@bricelam bricelam reopened this Aug 13, 2021
@bricelam bricelam removed this from the 6.0.0-preview3 milestone Aug 13, 2021
@bricelam bricelam added blocked and removed closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. labels Aug 13, 2021
bricelam added a commit to bricelam/efcore that referenced this issue Aug 16, 2021
@bricelam
SQLite: Revert connection pool PR
b8c69ed 
Since merging, the CI fail rate increased significantly from ericsink/SQLitePCL.raw#430

Fixes dotnet#16202, unresolves dotnet#13837
@bricelam bricelam mentioned this issue Aug 16, 2021
Closed
@bricelam bricelam added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 16, 2021
@bricelam bricelam added this to the 6.0.0-preview3 milestone Aug 16, 2021
@bricelam bricelam removed the blocked label Aug 16, 2021
bricelam added a commit to bricelam/efcore that referenced this issue Aug 16, 2021
@bricelam
SQLite: Revert connection pool PR
40e2cd1 
Since merging, the CI fail rate increased significantly from ericsink/SQLitePCL.raw#430

Fixes dotnet#16202, unresolves dotnet#13837
@bricelam bricelam closed this as completed Oct 5, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview3, 6.0.0 Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bricelam bricelam

Labels
area-adonet-sqlite area-perf closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
2 participants
@bricelam @ajcvickers