Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: Revert connection pool PR #25538

Closed
wants to merge 1 commit into from
Closed

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Aug 16, 2021

Since merging, the CI failure rate increased significantly from ericsink/SQLitePCL.raw#430

Fixes #16202, unresolves #13837

@bricelam bricelam requested a review from a team August 16, 2021 16:49
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@roji
Copy link
Member

roji commented Aug 16, 2021

😢 😢 😢

@ericsink
Copy link

I'm still trying to figure out ericsink/SQLitePCL.raw#430 -- I hope there's time to get this PR back in.

@ajcvickers
Copy link
Member

@ericsink I can't promise, but I think there is a good chance that if we get the underlying issue fixed in time to depend on it for RC2, then we will likely be able to still pull this in.

Since merging, the CI fail rate increased significantly from ericsink/SQLitePCL.raw#430

Fixes dotnet#16202, unresolves dotnet#13837
@bricelam
Copy link
Contributor Author

Superseded by #25541

@bricelam bricelam closed this Aug 16, 2021
@bricelam bricelam deleted the unpool branch September 16, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Microsoft.Data.Sqlite: Use Span overload of sqlite3_prepare_v2
4 participants