Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a logging event when the context pooling maximum size is exceeded #24817

Open
roji opened this issue Apr 30, 2021 · 0 comments
Open

Add a logging event when the context pooling maximum size is exceeded #24817

roji opened this issue Apr 30, 2021 · 0 comments

Comments

@roji
Copy link
Member

roji commented Apr 30, 2021

As part of the Fortunes optimizations, it was discovered that our context pooling maximum size wasn't high enough (aspnet/Benchmarks#1630). As suggested by @sebastienros, we should have a logging event for this - it's very easy to miss this (as we did) and think you're efficiently using context pooling, when in fact you're not.

IMHO it makes sense to fire this event only once, as a warning by default. Especially zealous applications (like our benchmarks) could configure this to throw an exception instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants