Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic support for DbDataSource #28266

Open
Tracked by #22961
roji opened this issue Jun 19, 2022 · 2 comments
Open
Tracked by #22961

Basic support for DbDataSource #28266

roji opened this issue Jun 19, 2022 · 2 comments

Comments

@roji
Copy link
Member

roji commented Jun 19, 2022

The new DbDataSource ADO.NET abstraction has been added to the runtime (dotnet/runtime#64812). This issue tracks adding the minimal support needed for it in EF Core, i.e. allowing UseSqlServer to accept a data source instead of a connection string (or DbConnection). If a data source is provided, creation of a DbConnection would simply default to getting the connection from that data source.

@roji
Copy link
Member Author

roji commented Jun 22, 2022

Consider picking up DbDataSource automatically from DI if one is registered, like we do for ILoggerFactory.

@roji
Copy link
Member Author

roji commented Jul 13, 2022

Npgsql support is being done in npgsql/efcore.pg#2429, without requiring any EF-side changes.

This is still important to support DbDataSource for other database providers, but that has little value until other providers actually implement their own data source implementations with their own features. Punting out of 7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants