Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLite: add a value generator for Int32 #300

Closed
borgdylan opened this issue Jun 10, 2014 · 4 comments
Closed

SQLite: add a value generator for Int32 #300

borgdylan opened this issue Jun 10, 2014 · 4 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@borgdylan
Copy link

Trying out the SQLite provider leaving key generation to EF fails as the only built-in generator is for Guids (not supported under SQLite).

@bricelam bricelam modified the milestones: 1.0.0-alpha3, 1.0.0-alpha2 Jun 24, 2014
@bricelam
Copy link
Contributor

The GUID generator will work; they get mapped to BLOB values by Microsoft.Data.SQLite.

#361 adds a value generator for columns that map to INTEGER PRIMARY KEY columns (including AUTOINCREMENT ones). By default, this means long properties.

The remaining work for this issue, I would consider to be a duplicate of #302.

@bricelam bricelam removed this from the 1.0.0-alpha3 milestone Jun 26, 2014
@rowanmiller
Copy link
Contributor

Discussed in triage and decided that we should just make Int32 properties work for identity (since this is a very common pattern in domain classes). We'll handle this by using a long column in the database - similar to what we do to make GUIDs work.

@bricelam
Copy link
Contributor

Per our decision, this may now depend on #242

@bricelam bricelam modified the milestones: 1.0.0-alpha3, 1.0.0-alpha4 Aug 18, 2014
@bricelam bricelam modified the milestones: 1.0.0-alpha4, 1.0.0-beta1 Aug 21, 2014
@bricelam bricelam modified the milestones: 1.0.0-rc1, 1.0.0-beta1 Oct 6, 2014
@bricelam bricelam modified the milestones: 1.0.0-rc1, Backlog Nov 25, 2014
@bricelam bricelam removed their assignment Dec 9, 2014
@bricelam bricelam self-assigned this Apr 16, 2015
@bricelam bricelam modified the milestone: Backlog Apr 16, 2015
@bricelam
Copy link
Contributor

Resolved by #2006

@bricelam bricelam added this to the 7.0.0-beta5 milestone Apr 28, 2015
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-beta5, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

4 participants