Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include extension points? #4991

Closed
dneimke opened this issue Apr 5, 2016 · 3 comments
Closed

Include extension points? #4991

dneimke opened this issue Apr 5, 2016 · 3 comments

Comments

@dneimke
Copy link

dneimke commented Apr 5, 2016

We have designed our application to include the notion of soft-deleting Entities. e.g. a IsDeleted flag on the Entity indicates that it is soft-deleted whereas a hard-delete does a physical delete on the data in the database.

Are there any extension points when using Include's that would allow us to filter out soft-deleted Entities from result sets?

Example:

var employees = employeeService.FindAll().Include(e => e.Address)

In the above example, employeeService's FindAll method filters soft-deleted data at the top level but it would be nice to have an unobtrusive way to filter Addresses to return only non soft-deleted rows.

@dneimke
Copy link
Author

dneimke commented Apr 6, 2016

Duplicate of #1833

@dneimke dneimke closed this as completed Apr 6, 2016
@gdoron
Copy link

gdoron commented Aug 1, 2016

@rowanmiller @Bartmax
Do you know what happened to issue #1833?
I get 404, but I know there was such an issue (I got email notifications for that issue, and this one was closed as a duplicate of it) and as AFAIK GitHub doesn't provide an API for deleting issues.

Anyway, both me and @Bartmax asked how can we do stuff like

.Include(x=> x.Images.Where(image => !image.IsDeleted)

Is there a different issue tracking it?
I searched quite a lot but couldn't find anything.

@gdoron
Copy link

gdoron commented Aug 1, 2016

Hmm, #1833 is working again.
Not sure what was the issue.

@ajcvickers ajcvickers reopened this Oct 16, 2022
@ajcvickers ajcvickers closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants