Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range Performance Improvements #5826

Closed
TIHan opened this issue Oct 25, 2018 · 3 comments
Closed

Range Performance Improvements #5826

TIHan opened this issue Oct 25, 2018 · 3 comments
Labels
Feature Improvement
Milestone
Backlog

Comments

@TIHan
Copy link
Contributor

TIHan commented Oct 25, 2018

Created this issue to track that we need possible perf improvements for handling ranges, especially since we merged this PR: #4476
@TIHan TIHan changed the title Range Performance Improvement Range Performance Improvements Oct 25, 2018
@TIHan TIHan mentioned this issue Oct 25, 2018
Merged
@cartermp cartermp added this to the Unknown milestone Oct 29, 2018
@cartermp cartermp mentioned this issue Jan 14, 2019
Closed
@cartermp
Copy link
Contributor

Using this issue to track any future work with ranges, likely in the context of a redesign so that we don't carry file information around.

@TIHan
Copy link
Contributor Author

TIHan commented Jan 14, 2019

The range type is 16 bytes now, which IIRC, 16 bytes is the upper bound size that a struct is recommended to be. So, we may actually be fine in regards to performance.

@dsyme
Copy link
Contributor

dsyme commented Apr 1, 2022

I'm closing this as we've no specific need to improve this that we've noticed

@dsyme dsyme closed this as completed Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Improvement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@TIHan @KevinRansom @cartermp @dsyme