Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/5.0.1xx-preview5] Update dependencies from dotnet/runtime #7490

Merged
merged 1 commit into from
May 18, 2020
Merged

[release/5.0.1xx-preview5] Update dependencies from dotnet/runtime #7490

merged 1 commit into from
May 18, 2020

Conversation

dotnet-maestro[bot]
Copy link

This pull request updates the following dependencies

From https://github.com/dotnet/runtime

  • Subscription: 1fdc5ea8-670d-4cce-383e-08d7f21e1787
  • Build: 20200513.12
  • Date Produced: 5/14/2020 8:43 PM
  • Commit: c39954c06937b5b40e3dab0621b1de950207bdf0
  • Branch: refs/heads/release/5.0-preview5
  • Updates:
    • Microsoft.NETCore.App.Runtime.win-x64: from 5.0.0-preview.6.20264.1 to 5.0.0-preview.5.20263.12
    • Microsoft.NETCore.DotNetHostResolver: from 5.0.0-preview.6.20264.1 to 5.0.0-preview.5.20263.12
    • Microsoft.NETCore.Platforms: from 5.0.0-preview.6.20264.1 to 5.0.0-preview.5.20263.12
    • Microsoft.NETCore.App.Host.win-x64: from 5.0.0-preview.6.20264.1 to 5.0.0-preview.5.20263.12
    • Microsoft.NETCore.App.Internal: from 5.0.0-preview.6.20264.1 to 5.0.0-preview.5.20263.12
    • Microsoft.NETCore.App.Ref: from 5.0.0-preview.6.20264.1 to 5.0.0-preview.5.20263.12

@dotnet-maestro
Update dependencies from https://github.com/dotnet/runtime build 2020…
9df69fd 
…0513.12

Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Internal , Microsoft.NETCore.App.Ref
 From Version 5.0.0-preview.6.20264.1 -> To Version 5.0.0-preview.5.20263.12
@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 14, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86), installer (build Darwin Build_Release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@lukas-lansky
Copy link

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 7490 in repo dotnet/installer

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 15, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@mmitche
Copy link
Member

mmitche commented May 15, 2020

@sfoslund @dsplaisted @wli3 Can you take a look here?

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 15, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@sfoslund
Copy link
Member

##[error]test/SdkTests/SdkTests.csproj(269,5): error MSB3073: (NETCORE_ENGINEERING_TELEMETRY=Build) The command "unset MSBuildSDKsPath && unset DOTNET_HOST_PATH && unset DOTNET_INSTALLDIR && dotnet tool run testSdkPack -- -noautoreporters -noRepoInference -dotnetPath /datadisks/disk1/workspace/_work/1/s/artifacts/bin/redist/Debug/dotnet-with-previous-runtimes/\dotnet -testExecutionDirectory /datadisks/disk1/workspace/_work/1/s/artifacts/tmp/Debug/dotnetSdkTests -testConfigFile "/datadisks/disk1/workspace/_work/1/s/test/SdkTests/TestConfig.xml" -xml "/datadisks/disk1/workspace/_work/1/s/artifacts/TestResults/Debug/Microsoft.NET.Pack.Tests.xml" -html "/datadisks/disk1/workspace/_work/1/s/artifacts/TestResults/Debug/Microsoft.NET.Pack.Tests.html" > /datadisks/disk1/workspace/_work/1/s/artifacts/log/Debug/Microsoft.NET.Pack.Tests.log 2>&1 -testList SdkIntegrationTests" exited with code 150.

This reminds me of the failure from #7005

@sfoslund sfoslund mentioned this pull request May 15, 2020
Merged
@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 15, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@mmitche
Copy link
Member

mmitche commented May 15, 2020

Okay should verify that all that was in p4 got into p5 for runtime.

@dotnet-maestro
Copy link
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@mmitche
Copy link
Member

mmitche commented May 15, 2020

Okay should verify that all that was in p4 got into p5 for runtime.

There are a lot of conflicts.

@Anipik Can you make sure that all the commits from p4 made it into runtime/master and p5?

/fyi @janvorli

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 15, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@janvorli
Copy link
Member

@sfoslund

This reminds me of the failure from #7005

What reminds you that issue? The exit code in the log is different - it is 150. If it is an error code stemming from a signal, then the signal causing the crash would be SIGTTOU, which would mean that a background process attempted to write to console.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 15, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@sfoslund
Copy link
Member

@janvorli my bad, I missed that.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 15, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Darwin Build_Release), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Windows_NT Build_Debug_x86)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@wli3
Copy link

wli3 commented May 17, 2020

@janvorli could you help me find someone from runtime team to lead the investigate of this insertion? We can help when the failure is obvious. However, it is ultimately component owner's responsibility to ensure the change get in.

@dotnet-maestro
Copy link
Author

dotnet-maestro bot commented May 17, 2020 •
edited
Loading

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: installer, installer (build Linux Build_LinuxPortable_Release_x64), installer (build Linux Build_Linux_musl_Debug_x64), installer (build Linux Build_Rhel_7_2_Release_x64), installer (build Darwin Build_Release), installer (build Linux Build_Debian_Stretch_Debug_x64), installer (build Linux Build_CentOS_7_1_Debug_x64), installer (build Linux Build_Fedora_29_Debug_x64), installer (build Windows_NT Build_Release_x64), installer (build Linux Build_Ubuntu_18_04_Debug_x64), installer (build Windows_NT Build_ES_Debug_x64), installer (build Linux Build_Ubuntu_16_04_Debug_x64), installer (build Windows_NT Build_Debug_x86), installer (build Linux Build_Arm64_Debug), installer (build Linux Build_Arm_Debug), installer (build Windows_NT Build_Release_arm64), installer (build Windows_NT Build_Release_arm)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.
  • ❌ Standard Merge Policies Some dependency updates are downgrades. Aborting auto-merge.

@lukas-lansky
Copy link

lukas-lansky commented May 18, 2020 •
edited
Loading

@ManickaP Please, can you merge this for me? My rights are still being worked on. The version downgrade is to be expected given this is previes5 branch.

/cc @mmitche

@ManickaP ManickaP merged commit 4934134 into release/5.0.1xx-preview5 May 18, 2020
@dotnet-maestro dotnet-maestro bot deleted the darc-release/5.0.1xx-preview5-179cf76f-a606-4447-a4a3-fa0b523647b1 branch May 18, 2020 08:30
@janvorli
Copy link
Member

@janvorli could you help me find someone from runtime team to lead the investigate of this insertion? We can help when the failure is obvious. However, it is ultimately component owner's responsibility to ensure the change get in.

I'll take a look myself.

@janvorli
Copy link
Member

Oh, I can see it got merged in. What has fixed the issue?

@wli3
Copy link

wli3 commented May 27, 2020

looks like @ManickaP merged this on a different branch

@janvorli
Copy link
Member

@wli3 please help me understand - does it mean the issue is still there and we need to investigate it?

@wli3
Copy link

wli3 commented May 27, 2020

The issue is gone. I think @ManickaP did something that fixed it

@lukas-lansky
Copy link

lukas-lansky commented May 28, 2020 •
edited
Loading

AFAIK @wli3, @janvorli we did nothing with @ManickaP; just bypassed the downgrade policy check. At the state we got into this, the real issue was already fixed.

Let me look into what changed between #7490 (comment) and #7490 (comment) .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lukas-lansky @mmitche @sfoslund @janvorli @wli3 @ManickaP