Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable a flaky test for SysFs #2023

Merged
merged 3 commits into from Jan 26, 2023
Merged

Disable a flaky test for SysFs #2023

merged 3 commits into from Jan 26, 2023

Conversation

pgrawehr
Copy link
Contributor

@pgrawehr pgrawehr commented Jan 22, 2023

This report indicates that this particular test is responsible for most of the helix test failures.

Microsoft Reviewers: Open in CodeFlow

Copy link
Member

@krwq krwq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joperezr
Copy link
Member

Have we found evidence of runs where ONLY this test fails? What I've seen in the past, is that sometimes a board would end up in a bad state of pinmode on the input pin and it essentially fails around 10 or so tests. If that's the case, then I think that this PR isn't really getting us much value, and it is dropping coverage. My suggestion is wait for a PR to fail the tests and validate that this test is the only one failing, sound good?

@pgrawehr
Copy link
Contributor Author

Have we found evidence of runs where ONLY this test fails? What I've seen in the past, is that sometimes a board would end up in a bad state of pinmode on the input pin and it essentially fails around 10 or so tests. If that's the case, then I think that this PR isn't really getting us much value, and it is dropping coverage. My suggestion is wait for a PR to fail the tests and validate that this test is the only one failing, sound good?

As I already have noted: This statistic shows that this is the only test that failed in all of the recent builds. I've manually checked 2 or 3 recent helix failures, and it was always this test (and only this test).

@joperezr
Copy link
Member

I see, sorry @pgrawehr I missed that. One last ask, can we please log an issue to track the fix of the test, and add a comment where you are disabling it to point to that issue? Basically the same thing that @krwq suggested.

@pgrawehr
Copy link
Contributor Author

Ticket #629 exists already.

The issue could also be related to #1581

@krwq krwq merged commit a0db92f into dotnet:main Jan 26, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants