Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable a flaky test for SysFs #2023

Merged
merged 3 commits into from Jan 26, 2023
Merged

Disable a flaky test for SysFs #2023

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1097962
Disable a flaky test for SysFs
pgrawehr Jan 22, 2023
16a6d91
Add ticket numbers
pgrawehr Jan 26, 2023
9695f94
Update src/System.Device.Gpio.Tests/GpioControllerTestBase.cs
krwq Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/System.Device.Gpio.Tests/GpioControllerTestBase.cs
View file
Open in desktop
Expand Up @@ -230,9 +230,17 @@ void Callback(object sender, PinValueChangedEventArgs pinValueChangedEventArgs)
[Fact]
public void AddCallbackFallingEdgeNotDetectedTest()
{
var driver = GetTestDriver();
if (driver is SysFsDriver)
{
// This test is unreliable (flaky) with SysFs.
pgrawehr marked this conversation as resolved.
Show resolved Hide resolved
// See https://github.com/dotnet/iot/issues/629 and possibly https://github.com/dotnet/iot/issues/1581
return;
}

bool wasCalled = false;
AutoResetEvent ev = new AutoResetEvent(false);
using (GpioController controller = new GpioController(GetTestNumberingScheme(), GetTestDriver()))
using (GpioController controller = new GpioController(GetTestNumberingScheme(), driver))
{
controller.OpenPin(InputPin, PinMode.Input);
controller.OpenPin(OutputPin, PinMode.Output);
Expand Down