add sample for si7021 temperature read over i2c #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we move the implementation of the si7021 binding over to src/devices/ ? The main idea we want is to (with the help of the community) add as much device bindings as we can in order to make it easier for people to port their apps to .NET Core, and it looks like you already bring in here part of that binding implementation so we might as well just move it there. |
|
Sure, let me look into moving this to src/devices |
|
@anphel31 are you still planing on moving this code to src/devices? |
|
Sorry for the delay, I've been on vacation, but yes I intend to move this to src/devices |
joshfree
reviewed
Jan 9, 2019
joshfree
suggested changes
Jan 9, 2019
|
Looks like this is missing the README files for both the sample and the main project. It is also missing the fritzing diagram. |
joperezr
reviewed
Jan 15, 2019
joperezr
reviewed
Jan 15, 2019
joperezr
reviewed
Jan 15, 2019
joperezr
reviewed
Jan 15, 2019
joperezr
reviewed
Jan 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add sample for si7021 temperature read over i2c