-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
F# samples need to be migrated to ML.NET v0.7 (minor migration from v0.6) #117
Comments
#117 migrated F# samples to ML.NET v0.7
@mariuszwojcik let's go for it. Which one you are picking up? @CESARDELATORRE is it ok if we use paket instead of nuget for F# samples ? F# community like that way. If you want I can open up new issue to discuss this. |
Sure, open an issue and let's discuss it with @dsyme ok? 👍 |
@kunjee17 hey, welcome back, hope you had great holiday. The basic four samples are already on v0.7. I am working on porting "Fraud detection" to F#, so if you wish you could port any other sample. |
@mariuszwojcik is your samples are already merged ? I ll pick it others. And also mention them here so we can stay in sync. |
@kunjee17 when you get the latest, all F# samples are in v0.7 and as I said, I am working on Fraud Detection |
@mariuszwojcik @Kunjee Hey guys! Thanks a lot for your work migrating the F# samples. We really appreciate it from Microsoft! 👍 - About continuing with further samples for F#, just a heads-up. I'd suggest if you want to migrate the following three samples, only, for now:
And even those (and the rest) might slightly be refactored in the upcoming days while reviewing the samples from an API point of view. But do NOT migrate the following as they will evolve quite a lot until we align them to the rest of samples:
Thanks! 👍 |
@CESARDELATORRE thanks for the heads up - much appreciated. In that case I will focus my efforts on Regression_BikeSharingDemand for now. Cheers! |
Regression_BikeSharingDemand sample has been migrated to F#. Next one to go would be MulticlassClassification-GitHubLabeler Cheers |
#117: Migrated BikeSharingDemand sample to F# (ML.NET v0.7)
I ll try for Clustering_CustomerSegmentation. |
@mariuszwojcik it would be good to separate common folder that can be reused ? I am as of now following your work and using your code only. But may be in future a nuget helper package would be good ? |
@kunjee17 there already is a common folder which is reused between all samples. You'll find there |
@CESARDELATORRE, earlier you mentioned that below projects will be going through major code changes and we should not convert them to F# yet. Can you update us on the status? I have just migrated
|
#117 migrated MulticlassClassification-GitHubLabeler sample to F#
I would wait some more time until the API is even more stable. Updating all the samples to F# every month means a significant amount of work. |
Closing this issue as it is stale |
We released v0.7 today (Nov. 6th) and there are a few minor breaking changes compared to v0.6 in some Estimators naming, most of all.
For now, I'm setting a special "Directory.Build.props" file targeting v0.6 for the F# samples until they are migrated to v0.7.
C# samples are most of them already migrated to v0.7, so contributors for F# can check it out in regards naming, etc.
The text was updated successfully, but these errors were encountered: