-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update build script and/or instructions to check for libomp on OS X #1282
Comments
My opinion is that we should do all of the following steps (sorted in easy-to-hard order):
Doing (2) above would help even when running the tests or trying to use LightGBM as a user. If we had a good error message that said I wouldn't update the build script to install global software on the machine. I think mutating machine state in that way is surprising to developers. Pulling down local copies of software into the repo is different than installing something into the equivalent of "Program Files". You also may need to run the build as
I would vote against this because there are users who just want to build the repo, and use other bits that aren't LightGBM. Forcing them to install software that they aren't going to use isn't a great experience IMO. |
I would recommend an error message (and related test) which gets the user to the solution faster. Perhaps, This extra user-orientated convince has trade-offs, for instance we have to specifically check for For the build script error: Generally when I build software, I expect all parts which I build to work. If they build LightGBM I think they also expect it to be usable. |
@justinormont , is this about documentation update? Is this fixed already? |
HI, I have deployed the application using dot net core 3.0 "Self Contained" profile on a new windows 2019 sever and have the same error. It's not limited to IOS. |
The build script does install libiomp 7.0 as evident from here , however we need to updated documentation for people using nugets that depend on mkl which depends on libiomp that they need libiomp v7.0 |
System information
Issue
LightGBM fails to run on OS X unless
libomp
is installed.A change 6 days ago added the requirement for
libomp
and we haven't updated the build instructions or build script.Error:
Temporary solution (fix it once for the current user)
On OS X, we can install libomp:
Longer term solutions (fix it again for all future users)
brew install libomp
libomp
and fail the build if missinglibomp
if missing--installing global system software during a build is bad though; is there a way to do a local install?libomp
and produce a helpful error--this issue affects nuget users ; perhaps a change to the upstream LightGBM (@guolinke, thoughts?)We should check if the
libomp
requirement increases the difficultly to distribute apps which call into ML.NET. Do the end-users (or the apps install script) have to installlibomp
?Thanks to @eerhardt for finding the
brew install libomp
solution and providing much of the above background information.The text was updated successfully, but these errors were encountered: