Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression/8.0.0-preview.5.8529] [Android] ListView doesn't get rendered #15826

Closed
stefanpirkl opened this issue Jun 23, 2023 · 3 comments · Fixed by #16941
Closed

[regression/8.0.0-preview.5.8529] [Android] ListView doesn't get rendered #15826

stefanpirkl opened this issue Jun 23, 2023 · 3 comments · Fixed by #16941
Assignees
@mauroa
Labels
area-controls-listview ListView and TableView delighter fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
.NET 8 GA

Comments

@stefanpirkl
Copy link

Description

If a ListView is set to IsVisible="False" on initital page load, it doesn't get rendered even if it's set to IsVisible="true" later.

Example:

App starts with first ListView visible:
image

On "Swap List", List 1 is set to invisible, List 2 is set to visible:
image

Was working on .Net 7, not anymore on .Net 8 preview.

Steps to Reproduce

  1. Create a new app
  2. Create two ListViews on MainPage, IsVisible bound to boolean properties List1Visible (true) and List2Visible (false)
  3. Create a button with code to swap visibility of the two ListViews
  4. On startup, ListView 1 is displayed
  5. On button click, ListView 2 is NOT displayed

Link to public reproduction project repository

https://github.com/stefanpirkl/bugreport-maui-android-listview-not-rendered

Version with bug

8.0.0-preview.5.8529

Last version that worked well

7.0.86

Affected platforms

Android, I was not able test on other platforms

Affected platform versions

Android 13

Did you find any workaround?

Setting both Lists to IsVisible="true" on initial load.

Relevant log output

No response
@stefanpirkl stefanpirkl added the t/bug Something isn't working label Jun 23, 2023
@jfversluis jfversluis added platform/android 🤖 area-controls-listview ListView and TableView i/regression This issue described a confirmed regression on a currently supported version labels Jun 23, 2023
@PureWeen PureWeen added this to the .NET 8 milestone Jun 23, 2023
@SarthakB26
Copy link

This would break my apps very bad :(

@stefanpirkl
Copy link
Author

stefanpirkl commented Jul 3, 2023 •
edited
Loading

This would break my apps very bad :(

It DOES break my app very bad too :(

@Redth Redth modified the milestones: .NET 8, .NET 8 GA Jul 12, 2023
@XamlTest XamlTest added platform/iOS 🍎 s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Jul 27, 2023
@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.7.0 Preview 5.0. Repro on Android 13.0-API33 and iOS 16.4 .NET 8, not repro on Windows 11 with below Project:
ListViewVisibleBug.zip

Displayed

@samhouts samhouts added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Jul 27, 2023
@samhouts samhouts changed the title [Android] [.Net 8] ListView doesn't get rendered [regression/8.0.0-preview.5.8529] [Android] ListView doesn't get rendered Aug 1, 2023
@mauroa mauroa self-assigned this Aug 16, 2023
mauroa added a commit that referenced this issue Aug 22, 2023
@mauroa
[android] Fixed ListView visibility and opacity on Android
3869bd8 
Visibility and Opacity settings were not working correctly when the control was inside a container.
For the case of visibility, it was only being set for the container when it needed to be set for both the container and the control.
For the case of opacity, it was also only being set for the container, which could reduce the opacity of the control as a side effect because it's a value affected by its parent value. In this case, we need to ensure the control has 100% opacity so it applies and uses the correct value to the container.

Fixes:
#15826
#15357
mauroa added a commit that referenced this issue Aug 22, 2023
@mauroa
Added Appium tests for issues #15826 and #15357
d82c4ec
mauroa added a commit that referenced this issue Aug 22, 2023
@mauroa
Added Appium tests for issues #15826 and #15357
3d86673
@mauroa mauroa mentioned this issue Aug 22, 2023
Merged
mauroa added a commit that referenced this issue Aug 23, 2023
@mauroa
Added Appium tests for Visibility issues #15826 and #15357
90e8f65
This was referenced Aug 25, 2023
Closed
Closed
Closed
Closed
Closed
Closed
@samhouts samhouts added the fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 label Sep 12, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mauroa mauroa

Labels
area-controls-listview ListView and TableView delighter fixed-in-8.0.0-rc.1.9171 Look for this fix in 8.0.0-rc.1.9171 i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint platform/android 🤖 platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet
Milestone
.NET 8 GA
Development

Successfully merging a pull request may close this issue.

[android] Fixed ListView visibility and opacity on Android dotnet/maui
9 participants
@davidortinau @Redth @jfversluis @mauroa @PureWeen @samhouts @stefanpirkl @XamlTest @SarthakB26