[android] Fixed ListView visibility and opacity on Android #16941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visibility and Opacity settings were not working correctly when the control was inside a container. For the case of visibility, it was only being set for the container when it needed to be set for both the container and the control. For the case of opacity, it was also only being set for the container, which could reduce the opacity of the control as a side effect because it's a value affected by its parent value. In this case, we need to ensure the control has 100% opacity so it applies and uses the correct value to the container. Fixes: #15826 #15357
mauroa
force-pushed
the
dev/mag/bug15826
branch
from
3d86673
to
a7533f9
Compare
PureWeen
requested changes
Aug 24, 2023
src/Controls/samples/Controls.Sample.UITests/Controls.Sample.UITests.csproj
Outdated
Show resolved
Hide resolved
PureWeen
approved these changes
Aug 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Visibility and Opacity settings were not working correctly when the control was inside a container.
For the case of visibility, it was only being set for the container when it needed to be set for both the container and the control.
For the case of opacity, it was also only being set for the container, which could reduce the opacity of the control as a side effect because it's a value affected by its parent value. In this case, we need to ensure the control has 100% opacity so it gets and uses the correct value of the container.
Also added Appium tests to test both issues.
fixes #15826
fixes #15357
fixes #16718
fixes #10303
fixes #16729
fixes #11499
fixes #12211