Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label Truncation and MaxLines options do not work when combined #20128

Closed
MitchBomcanhao opened this issue Jan 24, 2024 · 6 comments
Closed

Label Truncation and MaxLines options do not work when combined #20128

MitchBomcanhao opened this issue Jan 24, 2024 · 6 comments
Labels
area-controls-label Label, Span migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/windows 🪟 s/needs-attention Issue has more information and needs another look t/bug Something isn't working

Comments

@MitchBomcanhao
Copy link

MitchBomcanhao commented Jan 24, 2024

Description

This is not a new issue, it has been reported multiple times over the years, hasn't been fixed, and the previous bugs have been closed as if things were fixed.

see

I have found other issues in maui where properties set in xaml are simply not being applied to the controls (mainly when dealing with implicit styles, where some properties have no effect) so I'm wildly speculating this will be a similar issue. when setting up truncation properties, the maxlines setting is likely not getting set at all.

I've reproduced this on Windows and the older bugs also mention iOS and Android so I'm sure they'll also be broken.

Steps to Reproduce

In my case, I have a label set with LineBreakMode="TailTruncation" MaxLines="2" and it is rendered with a single truncated line.

If you want more details, be sure to check the referenced bugs above which have not been resolved.

Link to public reproduction project repository

No response

Version with bug

8.0.3

Is this a regression from previous behavior?

Yes, this used to work in Xamarin.Forms

Last version that worked well

Unknown/Other

Affected platforms

Windows

Affected platform versions

No response

Did you find any workaround?

No response

Relevant log output

No response

@MitchBomcanhao MitchBomcanhao added the t/bug Something isn't working label Jan 24, 2024
@samhouts samhouts added migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels Jan 25, 2024
@PureWeen
Copy link
Member

Can you test with the latest nightly build?
https://github.com/dotnet/maui/wiki/Nightly-Builds

@PureWeen PureWeen added the s/needs-info Issue needs more info from the author label Jan 26, 2024
@ghost
Copy link

ghost commented Jan 26, 2024

Hi @MitchBomcanhao. We have added the "s/needs-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

@ghost ghost added the s/no-recent-activity Issue has had no recent activity label Jan 30, 2024
@ghost
Copy link

ghost commented Jan 30, 2024

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. If it is closed, feel free to comment when you are able to provide the additional information and we will re-investigate.

@MitchBomcanhao
Copy link
Author

MitchBomcanhao commented Jan 31, 2024

8.0.6 (bad)
image

8.0.7-nightly.9952 (30 January 2024) (ok)
image

seems like its behaviour has changed in recent builds. the above screenshots are from Windows, have not tried this in other platforms.

@ghost ghost added s/needs-attention Issue has more information and needs another look and removed s/needs-info Issue needs more info from the author s/no-recent-activity Issue has had no recent activity labels Jan 31, 2024
@PureWeen
Copy link
Member

@MitchBomcanhao can we close this issue?

@MitchBomcanhao
Copy link
Author

MitchBomcanhao commented Mar 12, 2024

@PureWeen if the code change has reached production, then I think it can be closed. I think this (#14918) will be the change that has this fix? if so, released in 8.0.7.

@github-actions github-actions bot locked and limited conversation to collaborators Apr 18, 2024
@Eilon Eilon added area-controls-label Label, Span and removed legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor labels May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-label Label, Span migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/windows 🪟 s/needs-attention Issue has more information and needs another look t/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants