[Windows] Set CanDrag and AllowDrop only if needed
#22640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartyIX
added
platform/windows 🪟
t/perf
MartyIX
changed the title
CanDrag and AllowDrop only if neededCanDrag and AllowDrop only if needed
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
MartyIX
requested review from
jonathanpeppers and
Foda
and removed request for
Eilon and
jfversluis
|
@jsuarezruiz Are the test failures real or not? |
|
@Foda Could you take a look please? |
Foda
approved these changes
May 31, 2024
|
@PureWeen is this good to merge? |
rmarinho
approved these changes
Jun 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR makes it so that
_container.CanDragand_container.AllowDropare not set unnecessarily. The PR assumes that most of UI elements are not draggable and droppable by default.Speedscope
-> ~9% improvement
Issues Fixed
Contributes to #21787