Problems with Button and ImageButton

[david-maw]

Description

There are a variety of issues on Android (maybe other places too, but that's all I've tried).

The issues I've noticed are:

1. A Button has a Shadow that cannot be eliminated (an ImageButton does not)
2. CornerRadius is ignored (at least sometimes, I've seen it work when set from code),

I suspect there I've seen other issues in more complex circumstances, but these are the obvious simple ones.
MAUIButtons.zip

Steps to Reproduce

Test program and snapshots of the pages it produces attached

Version with bug

Preview 13 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android

Affected platform versions

Unknown, I tested only on Android 11

Did you find any workaround?

No response

Relevant log output

No response

[XamlTest]

Verified on Visual Studio Enterprise 2022 main 17.2.0 Preview 2.0 [32223.438.main]. Repro on Android with above project.

[J-Swift]

CornerRadius should be handled by this #4820. You can workaround it by converting to PX from DP when setting on Android.

You can "workaround" the shadow using this #2918 (comment). It loses some tapped state functionality though.

[jsuarezruiz]

Could you try again with Preview 14?. This should be fixed by #4820

[david-maw]

Done, it's better, the shadow issues on Android seem to be fixed, but to follow up on my suspicions about CornerRadious I added this to Button_Clicked:

if (sender is Button btn)
{
    if (btn.CornerRadius == 0)
    {
        btn.CornerRadius = 20;
        btn.BackgroundColor = Colors.PaleVioletRed;
    }
    else
    {
        btn.CornerRadius = 0;
        btn.BackgroundColor = Colors.PaleGreen;
    }
}
else if (sender is ImageButton ibtn)
{
    if (ibtn.CornerRadius == 0)
    {
        ibtn.CornerRadius = 20;
        ibtn.BackgroundColor = Colors.PaleVioletRed;
    }
    else
    {
        ibtn.CornerRadius = 0;
        ibtn.BackgroundColor = Colors.PaleGreen;
    }
}

As I suspected, it's not quite right, on Android it looks like the ImageButton CornerRadius is still being interpreted as PX not DP, the Button handling of the same property seems ok.

On Windows dynamically setting CornerRadius does not seem to do anything either on Button or ImageButton.

[J-Swift]

@jsuarezruiz / @Redth it looks like #4820 actually got orphaned on the release/6.0.2xx-preview13 branch, never being merged into p14.

[david-maw]

Seems like it's fixed in RC1, thanks