Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shell Tab is still visible after set Tab.IsVisible to false #8788

Open
SamShanWang opened this issue Jul 17, 2022 · 6 comments · Fixed by #24161 · May be fixed by #24999
Open

Shell Tab is still visible after set Tab.IsVisible to false #8788

SamShanWang opened this issue Jul 17, 2022 · 6 comments · Fixed by #24161 · May be fixed by #24999
Assignees
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.90 fixed-in-9.0.0-rc.2.24503.2 good first issue Good for newcomers platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@SamShanWang
Copy link

SamShanWang commented Jul 17, 2022

Description

In the beginning, there is one tab visible ( tab 1 ) and two tabs hidden ( tab 2 and tab 3 ) on a TabBar. Then I want to display tab 2 and tab 3. Meanwhile, hide tab 1.

  1. Here is the code to do it.

Tab2.IsVisible = true;
Tab3.IsVisible = true;
Tab1.IsVisible = false;

Run in Android platform, the result is:
image
If you tap 'Tab 3' tab header, the app will crash.

When run in Windows platform, the result is correct.

  1. If I use the code below.

Tab1.IsVisible = false;
Tab2.IsVisible = true;
Tab3.IsVisible = true;

Then run in Android platform, the result is correct.
image

But run in Windows platform, the app will crash.

A repro project is provided: https://github.com/SamShanWang/maui-shell-tab-hide-bug.git

Steps to Reproduce

  1. Load repro project in VS and run on Android platform.
  2. Click the menu item 'Tap me to reproduce bug on android' on flyout.
  3. Notice the view of TabBar.
  4. Tap 'Tab 3' tab header, the app crashes.
  5. Then run on Windows platform.
  6. Click the menu item 'Tap me to reproduce bug on windows' on flyout. Then the app crashes.

Version with bug

9.0.408 (current)

Last version that worked well

Unknown/Other

Affected platforms

Android, Windows, I was not able test on other platforms

Affected platform versions

Android 7.1, Android 9.0, Windows 10 version 19044.1826, I was not able test on other platform versions

Did you find any workaround?

No response

Relevant log output

No response

@SamShanWang SamShanWang added s/needs-verification Indicates that this issue needs initial verification before further triage will happen t/bug Something isn't working labels Jul 17, 2022
@Eilon Eilon added the area-controls-shell Shell Navigation, Routes, Tabs, Flyout label Jul 18, 2022
@rmarinho rmarinho added s/needs-repro Attach a solution or code which reproduces the issue platform/android 🤖 and removed s/needs-verification Indicates that this issue needs initial verification before further triage will happen s/needs-repro Attach a solution or code which reproduces the issue labels Jul 20, 2022
@dotnet dotnet deleted a comment Jul 20, 2022
@rmarinho
Copy link
Member

On Windows and iOS seems to work fine, but on Android i can reproduce the crash.

@rmarinho rmarinho added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Jul 20, 2022
@SamShanWang
Copy link
Author

@rmarinho It doesn't work fine on Windows.

  1. Please pull the newest repro project.
  2. Then run on Windows platform.
  3. Click the menu item 'Tap me to reproduce bug on windows' on flyout. Then the app crashes.

@samhouts samhouts added the fatal label Jul 20, 2022
@rmarinho rmarinho added the s/verified Verified / Reproducible Issue ready for Engineering Triage label Jul 21, 2022
@hartez hartez removed the fatal label Aug 1, 2022
@samhouts samhouts added this to the .NET 8 Planning milestone Jan 26, 2023
@samhouts samhouts added good first issue Good for newcomers and removed p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint labels Feb 6, 2023
@shawyunz
Copy link

shawyunz commented Apr 4, 2023

After encountering the same issue, I ran a series of tests and found that the problem only occurs when the "IsVisible" property is bound to the first tab.

@samhouts samhouts removed the s/verified Verified / Reproducible Issue ready for Engineering Triage label Apr 5, 2023
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels May 22, 2023
@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.7.0 Preview 1.0. This issue can be reproduced on Windows 11 and Android 13.0 with below project:
MauiAppShellTabHideBug.zip

Windows11: App crash after clicking 'Tap me to reproduce bug on windows' on flyout.
image

Android: App crash after clicking 'Tap me to reproduce bug on android' on flyout -> Tap 3.
image

@samhouts samhouts modified the milestones: .NET 8 Planning, Under Consideration Sep 27, 2023
@CusYaBasic
Copy link

Any update on this? I appear to be having a similar issue, however it's android crashing and not windows

@vibollee
Copy link

any update on this? im having the same issue. Simple navigation issue shouldnt take this long to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout fixed-in-8.0.90 fixed-in-9.0.0-rc.2.24503.2 good first issue Good for newcomers platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
None yet