[proposal] Add IgnoreSafeArea #17803
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PureWeen
commented
Oct 3, 2023
| @@ -137,6 +137,7 @@ public void SetScrolledPosition(double x, double y) | |||
| View _content; | |||
| TaskCompletionSource<bool> _scrollCompletionSource; | |||
| Rect _layoutAreaOverride; | |||
| private bool _ignoreSafeArea; | |||
There was a problem hiding this comment.
We might need to make this value a different default for catalyst vs iOS. Otherwise, the scrollviews content might go into the titlebar
Eilon
added
the
area-layout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
On the template the ScrollView currently has scrollbars because the content is allowed to scroll into the navbar area. If we add IgnoreSafeArea and map this to
ContentInsetAdjustmentBehaviorthen the ScrollViewAreas to Investigate
Issues Fixed
Fixes #17224