Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[regression/8.0.0-rc.1.9171] ScrollView always has a scroll bar on iOS #17224

Closed
mattleibow opened this issue Sep 5, 2023 · 8 comments
Closed

[regression/8.0.0-rc.1.9171] ScrollView always has a scroll bar on iOS #17224

mattleibow opened this issue Sep 5, 2023 · 8 comments
Assignees
@hartez
Labels
area-controls-scrollview ScrollView fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 fixed-in-8.0.10 fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone
.NET 8 SR3

Comments

@mattleibow
Copy link
Member

mattleibow commented Sep 5, 2023 •
edited
Loading

Description

The scrollview seems to always be scrollable on iOS with .NET 8 RC 1

Steps to Reproduce

  1. File | New | Maui App
  2. Deploy to iOS
  3. Observe the screen is scrollable

Link to public reproduction project repository

N/A

Version with bug

8.0.0-rc.1

Is this a regression from previous behavior?

Yes, this used to work in .NET MAUI

Last version that worked well

7.0.92

Affected platforms

iOS

Affected platform versions

iOS

Did you find any workaround?

No response

Relevant log output

No response
@mattleibow mattleibow added the t/bug Something isn't working label Sep 5, 2023
@PureWeen
Copy link
Member

PureWeen commented Sep 6, 2023 •
edited
Loading

related #16352

Side note, this isn't a regression it's just that we changed the default for SafeArea which causes this to happen. If you change the safe area in NET7 the same thing happens.

@PureWeen PureWeen added this to the .NET 8 GA milestone Sep 6, 2023
@samhouts samhouts added potential-regression This issue described a possible regression on a currently supported version., verification pending i/regression This issue described a confirmed regression on a currently supported version and removed potential-regression This issue described a possible regression on a currently supported version., verification pending labels Sep 7, 2023
@samhouts samhouts changed the title ScrollView always has a scroll bar on iOS [regression/8.0.0-rc.1] ScrollView always has a scroll bar on iOS Sep 7, 2023
@samhouts
Copy link
Member

samhouts commented Sep 7, 2023

I think I'll leave the regression label because it is an unexpected change in behavior. However, we should document the workaround here (change the safe area).

@Eilon Eilon added the area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter label Sep 11, 2023
@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Sep 15, 2023
@XamlTest
Copy link

XamlTest commented Sep 15, 2023 •
edited
Loading

Verified this on Visual Studio Enterprise 17.8.0 Preview 2.0. Repro on iOS 16.4(8.0.0-rc.1), not repro on Android 13.0-API33 with Maui template:
17224.zip

@samhouts samhouts changed the title [regression/8.0.0-rc.1] ScrollView always has a scroll bar on iOS [regression/8.0.0-rc.1.9171] ScrollView always has a scroll bar on iOS Sep 19, 2023
@PureWeen
Copy link
Member

PureWeen commented Sep 27, 2023 •
edited
Loading

Probably related:
#15897
#17022

@mikeparker104 mikeparker104 added the partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with label Sep 28, 2023
This was referenced Oct 3, 2023
Closed
Closed
@samhouts samhouts added the p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint label Oct 3, 2023
@PureWeen PureWeen assigned hartez and unassigned PureWeen Oct 11, 2023
@PureWeen PureWeen mentioned this issue Oct 18, 2023
Closed
hartez added a commit that referenced this issue Oct 24, 2023
@hartez
Ensure that viewport calculations for iOS ScrollView account for cont…
3d5561a 
…ent insets

Fixes #17224
@hartez hartez mentioned this issue Oct 24, 2023
Merged
PureWeen pushed a commit that referenced this issue Oct 24, 2023
@hartez
Ensure that viewport calculations for iOS ScrollView account for cont…
0cb5d80 
…ent insets (#18277)

* Ensure that viewport calculations for iOS ScrollView account for content insets
Fixes #17224

* Update baseline image
github-actions bot pushed a commit that referenced this issue Oct 24, 2023
@hartez
Ensure that viewport calculations for iOS ScrollView account for cont…
a86ca0f 
…ent insets Fixes #17224
PureWeen pushed a commit that referenced this issue Oct 25, 2023
@github-actions @hartez
[release/8.0.1xx-rc2.2] Ensure that viewport calculations for iOS Scr…
018baf9 
…ollView account for content insets (#18321)

* Ensure that viewport calculations for iOS ScrollView account for content insets Fixes #17224

* Update baseline image

---------

Co-authored-by: E.Z. Hart <hartez@gmail.com>
@hartez
Copy link
Contributor

hartez commented Oct 25, 2023

Fixed by #18277

@hartez hartez closed this as completed Oct 25, 2023
@PureWeen PureWeen reopened this Nov 8, 2023
@PureWeen PureWeen modified the milestones: .NET 8 GA, .NET 8 SR1 Nov 30, 2023
@mattleibow
Copy link
Member Author

@PureWeen did you intend to close this one?

@PureWeen
Copy link
Member

PureWeen commented Dec 1, 2023

@PureWeen did you intend to close this one?

This is fixed by this #18586 correct?

@mattleibow
Copy link
Member Author

Just checking. All good.

@jsuarezruiz jsuarezruiz mentioned this issue Dec 18, 2023
Merged
@samhouts samhouts added fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 labels Dec 19, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 19, 2024
@Eilon Eilon added area-controls-scrollview ScrollView and removed area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter labels May 14, 2024
@samhouts samhouts modified the milestones: .NET 8 SR1, .NET 8 SR3 Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@hartez hartez

Labels
area-controls-scrollview ScrollView fixed-in-8.0.0-rc.2.9511 Look for this fix in 8.0.0-rc.2.9511 fixed-in-8.0.10 fixed-in-8.0.100-rc.2.9530 Look for this fix in 8.0.100-rc.2.9530 i/regression This issue described a confirmed regression on a currently supported version p/1 Work that is important, and has been scheduled for release in this or an upcoming sprint partner/cat 😻 this is an issue that impacts one of our partners or a customer our advisory team is engaged with platform/iOS 🍎 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
MAUI SDK Ongoing
Status: Done
Milestone
.NET 8 SR3
Development

Successfully merging a pull request may close this issue.

[proposal] Add IgnoreSafeArea dotnet/maui
7 participants
@Eilon @hartez @mattleibow @PureWeen @samhouts @mikeparker104 @XamlTest