Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Lay out the nested scroll view correctly #1952

Merged
merged 1 commit into from Aug 5, 2021

Conversation

mattleibow
Copy link
Member

Description of Change

When running a layout of the nested scroll view, make sure to use local coordinates.

Might fix #1950

Additions made

None.

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • Does this PR introduce a new control? (If yes, add an example using SemanticProperties to the SemanticsPage)
  • APIs that modify focusability?
  • APIs that modify any text property on a control?
  • Does this PR modify view nesting or view arrangement in anyway?
  • Is there the smallest possibility that your PR will change accessibility?
  • I'm not sure, please help me

If any of the above checkboxes apply to your PR, then the PR will need to provide testing to demonstrate that accessibility still works.

@mattleibow mattleibow added this to the 6.0.100-preview.7 milestone Aug 5, 2021
@mattleibow mattleibow requested a review from hartez August 5, 2021 02:39
@Redth Redth merged commit 4508c82 into release/6.0.1xx-preview7 Aug 5, 2021
@Redth Redth deleted the dev/fix-1950 branch August 5, 2021 14:33
Redth added a commit that referenced this pull request Aug 5, 2021
* Clamp Grid coordinates for child views (#1947)

* Clamp Grid coordinates

* Use correct values

* bad coments

* Add span tests

* Add VisualDiagnostics calls to new Layout base (#1948)

* Lay out the nested scroll view correctly (#1952)

Might fix #1950

* Add VisualDiagnostics calls to new Layout base (#1948) (#1954)

Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants