Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clamp Grid coordinates for child views #1947

Merged
merged 5 commits into from
Aug 5, 2021

Conversation

mattleibow
Copy link
Member

Description of Change

Fixes #1943

@Redth Redth merged commit 1854f03 into release/6.0.1xx-preview7 Aug 5, 2021
@Redth Redth deleted the dev/clamp-grid-coords branch August 5, 2021 13:56
@Redth Redth added this to the 6.0.100-preview.7 milestone Aug 5, 2021
Redth added a commit that referenced this pull request Aug 5, 2021
* Clamp Grid coordinates for child views (#1947)

* Clamp Grid coordinates

* Use correct values

* bad coments

* Add span tests

* Add VisualDiagnostics calls to new Layout base (#1948)

* Lay out the nested scroll view correctly (#1952)

Might fix #1950

* Add VisualDiagnostics calls to new Layout base (#1948) (#1954)

Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>

Co-authored-by: Matthew Leibowitz <mattleibow@live.com>
Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@samhouts samhouts added the fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fixed-in-6.0.100-preview.7.3 Look for this fix in 6.0.100-preview.7.3!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Adding controls to rows in a grid that have no RowDefinition crashes
4 participants