Add VisualDiagnostics calls to new Layout base #1954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Redth
approved these changes
Aug 5, 2021
Redth
added a commit
that referenced
this pull request
Aug 5, 2021
* Clamp Grid coordinates for child views (#1947) * Clamp Grid coordinates * Use correct values * bad coments * Add span tests * Add VisualDiagnostics calls to new Layout base (#1948) * Lay out the nested scroll view correctly (#1952) Might fix #1950 * Add VisualDiagnostics calls to new Layout base (#1948) (#1954) Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com>
samhouts
added
the
area-layout
samhouts
added
the
fixed-in-6.0.100-preview.7.3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Cherry pick #1948 to p7
Fixes #1839