[Android] Fix Ripple effect with custom background (alternative to #17821) #20412

jsuarezruiz · 2024-02-07T07:58:08Z

Description of Change

Fix Ripple effect with custom background (alternative to #17821).

Ripple effects (without background, using backgound color, using a brush, etc)

Modifying also borders, corners etc

To test, use the added sample to the UITest project.

Also added a device test.

Issues Fixed

Fixes #17642

PureWeen · 2024-02-11T00:15:01Z

src/Core/src/Handlers/Button/ButtonHandler.Android.cs

 			base.DisconnectHandler(platformView);
 		}

 		// This is a Android-specific mapping
 		public static void MapBackground(IButtonHandler handler, IButton button)
 		{
-			handler.PlatformView?.UpdateBackground(button);
+			if (handler is ButtonHandler buttonHandler)


I don't think we need to case the handler. The PlatformView on IButtonHandler is MaterialButton

maui/src/Core/src/Handlers/Button/IButtonHandler.cs

Line 4 in 847a7af

using PlatformView = Google.Android.Material.Button.MaterialButton;

Right, but require the cast to ButtonHandler to access to the default drawable and pass it updating the Background.

jsuarezruiz · 2024-03-12T11:19:51Z

@Redth @PureWeen Can we prioritize this issue and include it in the next SR (with this fix or a different approach)?

jsuarezruiz · 2024-03-15T12:28:24Z

The failing Windows device test is unrelated

PureWeen · 2024-03-16T21:23:21Z

@Redth @PureWeen Can we prioritize this issue and include it in the next SR (with this fix or a different approach)?

Yea, @mattleibow is going to get this one buttoned up.

PureWeen · 2024-03-23T15:15:31Z

/rebase

src/Core/src/Graphics/PaintExtensions.Android.cs

jsuarezruiz · 2024-03-25T09:40:32Z

src/Core/src/Platform/Android/ButtonExtensions.cs

-				}
-			}
+		// Default obtained by running on Android 34 and inspecting the default drawable
+		const int DefaultCornerRadius = 4;


Are these values correct for all supported API levels?

I copied from 34, so maybe... I was hoping consistency is better but we can check later maybe so we can get this PR in.

This is material, so most likely the values are the same across all OS versions - but I have not checked.

jsuarezruiz · 2024-03-25T09:41:34Z

src/Core/src/Platform/Android/ButtonExtensions.cs

-					gradientDrawable?.SetColor(ColorStateList.ValueOf(solidPaint.Color.ToPlatform()));
-				}
+				// Copy the tints from a temporary button.
+				using var btn = new MaterialButton(context);


Passing the default drawable has been changed to copy the tints from a temporary button. It is not an operation that happens frequently, set a background and then removing it, but is this perhaps more expensive?

It is a bit more expensive, but we don't need to add fields to handlers and pass the default drawable around. That requires new APIs and a bunch of old ones not working. It is more expensive, but this is smei-temporary because all I am using is the tint:

var defaultTintList = btn.BackgroundTintList; var defaultColor = defaultTintList?.GetColorForState([R.Attribute.StateEnabled], AColor.Black) ?? AColor.Black;

A better option is to not do either and just figure out the default tint color. There is probably some theme resource or some API to just get the raw color. However the color goes from android resources to the main color of the button - some primary color thing. If we can do that in our code, it will just be reading a resource color from the android resources.

I'll create an issue to fix this.

PureWeen · 2024-04-02T15:22:37Z

My change was just fixing the Tizen API shipping txt file nothing functional.

OvrBtn · 2024-04-02T15:28:40Z

Hello, approximately when can we expect new MAUI version with this fix?

AlleSchonWeg · 2024-04-03T08:43:27Z

Hi @PureWeen and @jsuarezruiz ,
this issue is not completely fixed. You closed this #18857 (comment) as duplicate and link this issue: #17642 which closes this PR. But ImageButton has still no ripple effect. Normal button works.

PureWeen · 2024-04-04T08:31:35Z

Hello, approximately when can we expect new MAUI version with this fix?

Hopefully next week. In the mean time can you test the nightly and let us know how it works for you?

https://github.com/dotnet/maui/wiki/Nightly-Builds

OvrBtn · 2024-04-04T15:41:09Z

Hello, approximately when can we expect new MAUI version with this fix?

Hopefully next week. In the mean time can you test the nightly and let us know how it works for you?

https://github.com/dotnet/maui/wiki/Nightly-Builds

I've created a copy of my current project and I've upgraded it from .NET 7 to newest .NET 8 nightly build: 8.0.20-nightly.10431

I don't really have the ability to test iOS, but on Android buttons work just like in .NET 7 which is great :)

rudyspano · 2024-04-18T11:38:27Z

Hi @PureWeen .
How to simply change the White Color to another Color ? (Light mode...)

rudyspano · 2024-04-19T04:46:30Z

My solution:

            ButtonHandler.Mapper.AppendToMapping("RippleEffectCustomization", (handler, view) =>
            {
                //cf: https://github.com/dotnet/maui/blob/main/src/Core/src/Platform/Android/ButtonExtensions.cs
                const float DefaultRippleAlpha = 0.24f;

                var button = handler.PlatformView;

                if (button.Background is not RippleDrawable rippleDrawable)
                {
                    return;
                }

              ButtonHandler.Mapper.AppendToMapping("RippleEffectCustomization", (handler, view) =>
              {
                  //cf: https://github.com/dotnet/maui/blob/main/src/Core/src/Platform/Android/ButtonExtensions.cs
                  const float DefaultRippleAlpha = 0.24f;
  
                  var button = handler.PlatformView;
  
  
                  if (button.Background is not RippleDrawable rippleDrawable)
                  {
                      return;
                  }
  
                  rippleDrawable.SetColor(ColorStateList.ValueOf(Colors.Yellow.WithAlpha(DefaultRippleAlpha).ToPlatform()));
              });

@PureWeen , is there a simpler way ?

It overrides this part of code. I cannot set platformView.RippleColor (always null after setting)

jsuarezruiz added 4 commits February 6, 2024 16:24

Other approach to fix the issue

1d21f41

More changes

01e9a73

Fixed Stroke

ca66bf2

Added device test

74d91c5

jsuarezruiz added t/bug Something isn't working platform/android 🤖 area-drawing Shapes, Borders, Shadows, Graphics, BoxView, custom drawing area-controls-button Button, ImageButton labels Feb 7, 2024

jsuarezruiz requested a review from a team as a code owner February 7, 2024 07:58

jsuarezruiz requested review from jfversluis and PureWeen February 7, 2024 07:58

ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Feb 7, 2024

Updated sample

6f03028

jsuarezruiz marked this pull request as draft February 7, 2024 10:04

More changes

aababcb

jsuarezruiz marked this pull request as ready for review February 7, 2024 12:47

Updated test

210ba39

PureWeen reviewed Feb 11, 2024

View reviewed changes

jsuarezruiz added 5 commits February 13, 2024 12:38

Merge branch 'main' into fix-17642-III

0f69064

Fix build errors

9cf97dc

Merge branch 'main' into fix-17642-III

d36a870

Merge branch 'main' into fix-17642-III

3424879

Fix format

1608eec

jsuarezruiz requested a review from PureWeen March 5, 2024 14:35

Merge branch 'main' into fix-17642-III

eaeeb65

Merge branch 'main' into fix-17642-III

2c23da6

mattleibow self-assigned this Mar 15, 2024

jsuarezruiz and others added 5 commits March 20, 2024 09:08

Merge branch 'main' into fix-17642-III

6ae08da

Merge branch 'main' into fix-17642-III

795f8dc

working

9c6d84d

So much done here!

8844779

- fix Tizen

4a3065d

jsuarezruiz commented Mar 25, 2024

View reviewed changes

mattleibow mentioned this pull request Apr 2, 2024

Resetting the button background creates a temporary button #21579

Open

PureWeen approved these changes Apr 2, 2024

View reviewed changes

PureWeen merged commit 49676d2 into main Apr 2, 2024
47 checks passed

PureWeen deleted the fix-17642-III branch April 2, 2024 15:22

jsuarezruiz mentioned this pull request Apr 4, 2024

[Android] Fix Ripple Effect in ImageButton #21638

Closed

Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] Fix Ripple effect with custom background (alternative to #17821) #20412

[Android] Fix Ripple effect with custom background (alternative to #17821) #20412

jsuarezruiz commented Feb 7, 2024 •

edited

PureWeen Feb 11, 2024

jsuarezruiz Feb 27, 2024

jsuarezruiz commented Mar 12, 2024

jsuarezruiz commented Mar 15, 2024

PureWeen commented Mar 16, 2024

PureWeen commented Mar 23, 2024

jsuarezruiz Mar 25, 2024

mattleibow Mar 28, 2024

mattleibow Mar 28, 2024

jsuarezruiz Mar 25, 2024

mattleibow Apr 2, 2024

mattleibow Apr 2, 2024

PureWeen commented Apr 2, 2024

OvrBtn commented Apr 2, 2024

AlleSchonWeg commented Apr 3, 2024

PureWeen commented Apr 4, 2024

OvrBtn commented Apr 4, 2024 •

edited

rudyspano commented Apr 18, 2024 •

edited

rudyspano commented Apr 19, 2024 •

edited

[Android] Fix Ripple effect with custom background (alternative to #17821) #20412

[Android] Fix Ripple effect with custom background (alternative to #17821) #20412

Conversation

jsuarezruiz commented Feb 7, 2024 • edited

Description of Change

Issues Fixed

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jsuarezruiz commented Mar 12, 2024

jsuarezruiz commented Mar 15, 2024

PureWeen commented Mar 16, 2024

PureWeen commented Mar 23, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PureWeen commented Apr 2, 2024

OvrBtn commented Apr 2, 2024

AlleSchonWeg commented Apr 3, 2024

PureWeen commented Apr 4, 2024

OvrBtn commented Apr 4, 2024 • edited

rudyspano commented Apr 18, 2024 • edited

rudyspano commented Apr 19, 2024 • edited

jsuarezruiz commented Feb 7, 2024 •

edited

OvrBtn commented Apr 4, 2024 •

edited

rudyspano commented Apr 18, 2024 •

edited

rudyspano commented Apr 19, 2024 •

edited