-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android] Fix Ripple Effect in ImageButton #21638
Conversation
platformButton.Background = paint?.ToDrawable(platformButton.Context); | ||
if (paint is not null) | ||
{ | ||
// TODO: Assign Ids to detect if we already created the RippleDrawable to just |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@PureWeen @mattleibow Different Views are used for Button and ImageButton and they have classes with different extension methods as well. However, the fix may be similar to Button one. Wrap the drawable with the Background with a RippleDrawable that we only create once, and subsequent updates, we modify the one created.
Thoughts?
Hi, |
Description of Change
Fix Ripple Effect in ImageButton.
Issues Fixed
Fixes #18857
Related with #20412 (comment)