Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageButton ripple effect stops working with .NET 8 #18857

Closed
FreakyAli opened this issue Nov 17, 2023 · 12 comments · Fixed by #22298
Closed

ImageButton ripple effect stops working with .NET 8 #18857

FreakyAli opened this issue Nov 17, 2023 · 12 comments · Fixed by #22298
Assignees
Labels
area-controls-button Button, ImageButton fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10 i/regression This issue described a confirmed regression on a currently supported version migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Milestone

Comments

@FreakyAli
Copy link

FreakyAli commented Nov 17, 2023

Description

Ripple effect seems to stop working after upgrading to .NET 8 on all ImageButton for Android.

Relevant Screenshots

Steps to Reproduce

  1. Add an ImageButton to your page with padding,
  2. Notice how the default ripple effect stops working
iOS Android

Link to public reproduction project repository

https://github.com/FreakyAli/Maui.FreakyControls/tree/r4-gh/fix/pin-control

Version with bug

8.0.3

Is this a regression from previous behavior?

No, this is something new

Last version that worked well

7.0.101

Affected platforms

Android

Affected platform versions

Android 12 and 13

Did you find any workaround?

NO

Relevant log output

No response

@FreakyAli FreakyAli added the t/bug Something isn't working label Nov 17, 2023
@FreakyAli FreakyAli changed the title ImageButton Padding stops working with .NET 8 ImageButton Padding & Ripple effect stops working with .NET 8 Nov 17, 2023
@cropyai
Copy link

cropyai commented Nov 18, 2023

I can confirm the issue, currently, we are having the same problem in Android app.

@FreakyAli
Copy link
Author

@cropyai Yeah, the thing is ImageButtons and Buttons don't have Ripple effects, This is devastating, to be honest!!!

@PureWeen
Copy link
Member

Related #18857

@jsuarezruiz jsuarezruiz added the area-controls-button Button, ImageButton label Nov 20, 2023
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Nov 20, 2023
@FreakyAli
Copy link
Author

FreakyAli commented Nov 21, 2023

Related #18857

@PureWeen I think you tagged the wrong issue here!!

@albyrock87
Copy link
Contributor

Is this same as
#18924 (comment) ?

@XamlTest
Copy link

Verified this on Visual Studio Enterprise 17.9.0 Preview 2(8.0.3). Repro on Android 14.0-API34, not repro on iOS 17.0 with below Project:
MAUI.FreakyControls.zip

@XamlTest XamlTest added s/verified Verified / Reproducible Issue ready for Engineering Triage s/triaged Issue has been reviewed labels Dec 20, 2023
@NoelleRousselle
Copy link

I also can confirm this issue. Is there any workaround?

@FreakyAli
Copy link
Author

I also can confirm this issue. Is there any workaround?

@NoelleRousselle There was no workaround for now so I created a lib with native click animations and started using Images https://github.com/FreakyAli/Maui.FreakyEffects

@rachelkang rachelkang added migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert potential-regression This issue described a possible regression on a currently supported version., verification pending labels Jan 23, 2024
@PureWeen
Copy link
Member

Duplicate of #17642

@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@mattleibow mattleibow changed the title ImageButton Padding & Ripple effect stops working with .NET 8 ImageButton ripple effect stops working with .NET 8 May 13, 2024
@mattleibow
Copy link
Member

I split this issue into ripple and padding. This issue is now ripple-only. The new issue is for the padding: #22364

@FreakyAli
Copy link
Author

@mattleibow This does not work with the latest version of .NET MAUI v8.0.40,

Why was this closed?

@mattleibow
Copy link
Member

Why was this closed?

Typically, the issues are closed when the code is merged into the main branch. This does not mean that the issue is fixed and shipped. However, we have nightly builds that you can test and use.

We also release new versions to NuGet periodically outside of VS release schedules that you can use. This fix is not yet part of any official release.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2024
@samhouts samhouts added fixed-in-9.0.0-preview.5.24307.10 fixed-in-8.0.60 i/regression This issue described a confirmed regression on a currently supported version and removed potential-regression This issue described a possible regression on a currently supported version., verification pending labels Jul 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-button Button, ImageButton fixed-in-8.0.60 fixed-in-9.0.0-preview.5.24307.10 i/regression This issue described a confirmed regression on a currently supported version migration-compatibility Xamarin.Forms to .NET MAUI Migration, Upgrade Assistant, Try-Convert platform/android 🤖 s/triaged Issue has been reviewed s/verified Verified / Reproducible Issue ready for Engineering Triage t/bug Something isn't working
Projects
Status: Done