[X] Optimize OnPlatform element syntax #5611

StephaneDelcroix · 2022-03-28T13:27:50Z

fixes (but reverted) XamlC should optimize OnPlatform #5583

Description of Change

StephaneDelcroix · 2022-03-28T13:28:27Z

/cc @eerhardt could you give it a try ?

src/Controls/src/Xaml/XamlNode.cs

eerhardt · 2022-03-28T19:36:33Z

src/Controls/src/Xaml/SimplifyOnPlatformVisitor.cs

 			{
-				if (!ApplyPropertiesVisitor.TryGetPropertyName(node, parentNode, out XmlName name))
+				var onNode = GetOnNode(node, Target) ?? GetDefault(node);


onNode can be null here, right? Is it safe to pass it into ApplyPropertiesVisitor.TryGetPropertyName?

we don't pass it to TryGetPropertyName. TryGetPropertyName is a child asking his mom "what's my name again?" and is used to find the property is set to. OTOH, onNode is the child of , and of type

eerhardt · 2022-03-28T19:44:21Z

src/Controls/src/Xaml/SimplifyOnPlatformVisitor.cs

+					if (onNode != null)
+						parentEnode.Properties[name] = onNode;
+					else
+						parentEnode.Properties.Remove(name);


One thing I just noticed is that we add these attributes to the InitializeComponent() method:

[GeneratedCode("Microsoft.Maui.Controls.SourceGen", "1.0.0.0")] [MemberNotNull("selfMediaElementView")] [MemberNotNull("searchBar")] private void InitializeComponent() {

However, we are removing the initialization of some of these fields, for example the searchBar field in the Podcasts Header control. I'm not sure how to handle this though.... Thoughts?

this is generated by our SourceGen which is a different beast. but should indeed be fixed

there. see latest commit

jonathanpeppers · 2022-07-19T19:14:50Z

@StephaneDelcroix is this one we can revive in .NET 7/MAUI?

Is there even anything left? Maybe just a merge conflict?

StephaneDelcroix · 2022-07-20T06:46:25Z

@jonathanpeppers we need to uplift the source generator to use the same parser as the compiler, so it can skip field generation for the x:Names that have been removed

github-actions · 2023-05-31T08:00:40Z

Thank you for your pull request. We are auto-formatting your source code to follow our code guidelines.

StephaneDelcroix · 2023-06-13T13:54:47Z

@eerhardt finally spent the time to skip generation of fields for removed nodes in CodeBehindGenerator. could you look at this again ?

src/Controls/src/SourceGen/CodeBehindGenerator.cs

src/Controls/src/SourceGen/Controls.SourceGen.csproj

src/Controls/src/Xaml/SimplifyOnPlatformVisitor.cs

- fixes #5583

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>

StephaneDelcroix · 2023-08-08T15:39:08Z

/azp run MAUI-UITests-public

azure-pipelines · 2023-08-08T15:39:19Z

Azure Pipelines successfully started running 1 pipeline(s).

* Add swipe for uitests * Bump the androidx group with 1 update (#16474) Bumps the androidx group with 1 update: [Xamarin.AndroidX.RecyclerView](https://github.com/xamarin/AndroidX). - [Commits](https://github.com/xamarin/AndroidX/commits) --- updated-dependencies: - dependency-name: Xamarin.AndroidX.RecyclerView dependency-type: direct:production update-type: version-update:semver-patch dependency-group: androidx ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Document Element (#16299) * Begin doc progress * Document element * More explicit interface implementations * Address PR feedback * Document interfaces + delete xml * whitespace * Prevent compile issues * Document IElementController (and mark as obsolete) * Remove Obsolete attribute from IElementController This would break the build in various places - and would go out of scope of the PR * Document IVusalElementController Apparently is only for internal use. We can't make it private so the only choice is to mark everything as for internal use only * Prevent mdoc from breaking You can't really cref a namespace * Fixed other crefs * Address Dave's feedback * Move powershell pack script into cake (#16588) * 'pwsh' is broken on net8 PowerShell/PowerShell#19679 * Remove the script * oops * Fix Graphics Font comparison method (#15985) * Fix the issue * Added more tests * Updated Impl * [WinUI] Implement PointerPressed and PointerReleased (#16213) * Implement on Windows and add unit tests * Update src/Controls/src/Core/PointerGestureRecognizer.cs Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> --------- Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> * [X] Optimize OnPlatform element syntax (#5611) * [X] Optimize OnPlatform element syntax - fixes #5583 * Auto-format source code * don't generate x:Name for removed OnPlatforms * Update src/Controls/src/SourceGen/Controls.SourceGen.csproj Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> * fix string comparison --------- Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> * [Housekeeping] Add 8.0 preview 7 (#16613) also adds a checkbox to make it clear if this is a regression or not * [X] Support DynResources as AppThemeBinding values (#16597) Because, you know, why not ? It could be useful - fixes #13619 * [main] Update dependencies from dotnet/xharness (#16600) * Update dependencies from https://github.com/dotnet/xharness build 20230807.2 Microsoft.DotNet.XHarness.CLI , Microsoft.DotNet.XHarness.TestRunners.Common , Microsoft.DotNet.XHarness.TestRunners.Xunit From Version 8.0.0-prerelease.23403.1 -> To Version 8.0.0-prerelease.23407.2 * Run device tests on 16.4 * Force to 16.4 * Skip test that fails on iOS --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> * Adds prompts when creating a new page. (#16331) * Adds prompts when creating a new page. * Updates description as per suggested PR comments * [ios] fix memory leak in GraphicsView (#16605) Context: #16346 This addresses the memory leak discovered by: src/Core/src/Platform/iOS/PlatformTouchGraphicsView.cs(12,29): error MA0002: Member '_hoverGesture' could cause memory leaks in an NSObject subclass. Remove the member, store the value as a WeakReference, or add the [UnconditionalSuppressMessage("Memory", "MA0002")] attribute with a justification as to why the member will not leak. I could reproduce a leak in `MemoryTests.cs`: ++[InlineData(typeof(GraphicsView))] public async Task HandlerDoesNotLeak(Type type) Solved the problem by fixing two places: * `PlatformTouchGraphicsView` now stores the `IGraphicsView` as a `WeakReference`. * A `UIHoverGestureRecognizerProxy` is used for callbacks to the `UIHoverGestureRecognizer`. * [create-pull-request] automated change (#16592) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Setting binding on Label doesn't set text to incoming binding (#16410) * Test demonstrating binding issue * [C] SetBinding overrides SetValue, but only when the value is set * - reenable tests --------- Co-authored-by: Stephane Delcroix (HE/HIM) (from Dev Box) <stdelc@microsoft.com> * Added DeviceTest to validate CharacterSpacing on iOS Button (#16603) * Use runtime check for setting WKWebView inspectable flag (#16631) * Use runtime check * Remove private * Add back line * Line endings? * Use System.OperatingSystem * Update src/BlazorWebView/src/Maui/iOS/BlazorWebViewHandler.iOS.cs Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> --------- Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> * [Housekeeping] Fix broken bug template (#16643) * [Housekeeping] Fix broken bug template checkbox <> checkboxes * Update bug-report.yml * Update bug-report.yml * Implement Additional PointerGestureRecognizer Platform Arguments (#16426) * Pointer Platform Event Args * remove extension and use property instead * make ctor internal * nullable consistency, spelling, and private setter * Public API changes and remove nullable windows routedargs * uitests part 1 * only run ui tests on windows and mac * move device conditional to test * Change the tests to Pointer Tests for more reusability * Add documentation * Add extension method for ignoring platforms * Update the documentation * Change platform specific docs * [C] fix Specificity for VSM (#16404) * [C] fix Specificity for VSM - fixes #11204 * remove skipped test * Prevent Android timer from adding multiple callbacks; (#16078) Fixes #10257 * [Housekeeping] Remove checkboxes from bug template (#16650) I did not realize that they would be editable tasks on the issue. Replaced with a dropdown. Also reordered the versions to be the most likely default options to speed up the reporting process. * [Android] Fix SwipeView not swiping using Label as direct content (#14824) * Fix Android SwipeView not swiping using Label as Content * Refactoring code * Added sample to validate 6154 --------- Co-authored-by: Javier Suárez <6755973+jsuarezruiz@users.noreply.github.com> * Locate MAUI View for PlatformView (#16463) * Locate xplat view from platformview * - dispatcher * - fix layout comparison on xunit * - PR review comments * - tizen fix * Bump the aspnetcore group with 7 updates (#16634) Bumps the aspnetcore group with 7 updates: | Package | Update | | --- | --- | | [Microsoft.AspNetCore.Authorization](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Components.WebView](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.JSInterop](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Components.Web](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Authentication.Facebook](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Authentication.Google](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | | [Microsoft.AspNetCore.Authentication.MicrosoftAccount](https://github.com/dotnet/aspnetcore) | 7.0.9 to 7.0.10 | Updates `Microsoft.AspNetCore.Authorization` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Components.WebView` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.JSInterop` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Components.Web` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Authentication.Facebook` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Authentication.Google` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) Updates `Microsoft.AspNetCore.Authentication.MicrosoftAccount` from 7.0.9 to 7.0.10 - [Release notes](https://github.com/dotnet/aspnetcore/releases) - [Changelog](https://github.com/dotnet/aspnetcore/blob/main/docs/ReleasePlanning.md) - [Commits](dotnet/aspnetcore@v7.0.9...v7.0.10) --- updated-dependencies: - dependency-name: Microsoft.AspNetCore.Authorization dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Components.WebView dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.JSInterop dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Components.Web dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.Facebook dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.Google dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore - dependency-name: Microsoft.AspNetCore.Authentication.MicrosoftAccount dependency-type: direct:production update-type: version-update:semver-patch dependency-group: aspnetcore ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [create-pull-request] automated change (#16655) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * [ios] fix memory leak in SwipeItem (#16614) Context: #16346 This addresses the memory leak discovered by: src/Core/src/Handlers/SwipeItemMenuItem/SwipeItemMenuItemHandler.iOS.cs(10,30): error MA0001: Event 'FrameChanged' could cause memory leaks in an NSObject subclass. Remove the event or add the [UnconditionalSuppressMessage("Memory", "MA0001")] attribute with a justification as to why the event will not leak. I could reproduce the leak with a custom test in `SwipeViewTests`. Solved the problem by introducing `SwipeItemButtonProxy` with the same pattern from other PRs. * [ios/catalyst] fix memory leak in DatePicker (#16589) Context: #16346 This addresses the memory leak discovered by: src/Core/src/Platform/iOS/MauiDatePicker.cs(37,27): error MA0003: Subscribing to events with instance method 'OnValueChanged' could cause memory leaks in an NSObject subclass. Remove the subscription or convert the method to a static method. I could reproduce a leak in `MemoryTests.cs`: ++[InlineData(typeof(DatePicker))] public async Task HandlerDoesNotLeak(Type type) Solved the problem by fixing two places: * `MauiDatePicker` now uses a `UIDatePickerProxy` type, for iOS * `DatePickerHandler.MacCatalyst.cs` now uses a `UIDatePickerProxy` type, for MacCatalyst. Other changes: * Skip test on Android API 23 This is working for me locally on an API 23 emulator -- so I don't think it is really leaking. We skipped API 23 in another place: https://github.com/dotnet/maui/blob/9fcccd57b5a3d664e4788b3c7fc3edc10010beaf/src/Controls/tests/DeviceTests/Elements/NavigationPage/NavigationPageTests.cs#L302-L303 We are more interested in iOS on this PR anyway. * [build] Bump XCode to 14.31 (#16374) * Add doc comments for common types used in templates, maps, webview (#16552) * Add doc comments for common types used in templates, maps, webview * Enable WarnigsAsErrors for inline docs on Maps I went through every type/method/etc. used in the default MAUI app template and ensured there are doc for all of them. I also added a few miscellaneous docs for WebView types and Map (many were copied from Xamarin.Forms docs). --------- Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com> * Update CODEOWNERS (#16682) * Fix the case where silent was requested (#16676) * Use the correct WASDK property (#16683) * Re-land "[Windows] fixing window glitches while moving or resizing" (#16637) Initially merged in #14861 but there was a few test failures due to 83398c3 so it was reverted in #16541 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.tvOS.Sdk From Version 16.4.8694-net8-p7 -> To Version 16.4.8751-net8-rc1 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.MacCatalyst.Sdk From Version 16.4.8694-net8-p7 -> To Version 16.4.8751-net8-rc1 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.macOS.Sdk From Version 13.3.8694-net8-p7 -> To Version 13.3.8751-net8-rc1 * Update dependencies from https://github.com/xamarin/xamarin-macios build 20230815.5 Microsoft.iOS.Sdk From Version 16.4.8694-net8-p7 -> To Version 16.4.8751-net8-rc1 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Scott Banning <scoban@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Juan Diego Herrera <juherrera@microsoft.com> Co-authored-by: Matthew Leibowitz <mattleibow@live.com> Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com> Co-authored-by: Rachel Kang <rachelkang@microsoft.com> Co-authored-by: Samantha Houts <samhouts@users.noreply.github.com> Co-authored-by: Stephane Delcroix <stephane@delcroix.org> Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Rui Marinho <me@ruimarinho.net> Co-authored-by: Mausam Shrestha <46900712+mausam-shrestha@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Shane Neuville <shneuvil@microsoft.com> Co-authored-by: Stephane Delcroix (HE/HIM) (from Dev Box) <stdelc@microsoft.com> Co-authored-by: Tim Miller <drasticactions@users.noreply.github.com> Co-authored-by: Rolf Bjarne Kvinge <rolf@xamarin.com> Co-authored-by: TJ Lambert <50846373+tj-devel709@users.noreply.github.com> Co-authored-by: E.Z. Hart <hartez@users.noreply.github.com> Co-authored-by: Javier Suárez <6755973+jsuarezruiz@users.noreply.github.com> Co-authored-by: scoban <sbanni@users.noreply.github.com> Co-authored-by: Eilon Lipton <Eilon@users.noreply.github.com>

As reported in #17461, OnPlatform simplification cause some issues - while used as a Resource (#17461, unable to unit test for now) - doesn't type convert. On nodes shouldn't be replaced by the Value, but an element node (<On Platform="..." Value="Red" /> should generate <Color x:Key="foo">Red</Color>. right now it only generated "Red" - fixes #17461

Context: dotnet/maui#5611 Fixes: #239 The `net8.0` branch currently fails to build with: src/Mobile/Controls/Player.xaml.cs(54,9): error CS0103: The name 'podcastImage' does not exist in the current context src/Mobile/Controls/Player.xaml.cs(55,9): error CS0103: The name 'duration' does not exist in the current context We think that `x:Name` in .NET 8 appropriately "skips" emitting fields when used in combination with `<OnPlatform/>`. We can condition the C# code accessing these files with `#if WINDOWS || MACCATALYST` to solve this. There are also a lot places using `<On Platform="UWP, macOS">`, we could consider cleaning these up in a future PR.

As reported in #17461, OnPlatform simplification cause some issues - while used as a Resource (#17461, unable to unit test for now) - doesn't type convert. On nodes shouldn't be replaced by the Value, but an element node (<On Platform="..." Value="Red" /> should generate <Color x:Key="foo">Red</Color>. right now it only generated "Red" - fixes #17461

Context: dotnet/maui#5611 Fixes: #239 The `net8.0` branch currently fails to build with: src/Mobile/Controls/Player.xaml.cs(54,9): error CS0103: The name 'podcastImage' does not exist in the current context src/Mobile/Controls/Player.xaml.cs(55,9): error CS0103: The name 'duration' does not exist in the current context We think that `x:Name` in .NET 8 appropriately "skips" emitting fields when used in combination with `<OnPlatform/>`. We can condition the C# code accessing these fields with `#if`. Secondly, there are also a lot places using `<On Platform="UWP, macOS">`, we need to change these to: * `macOS` -> `MacCatalyst` Lastly, use .NET 8 RC 2 released bits. We shouldn't need to be using nightly builds in this repo.

* [X] revert #5611 As reported in #17461, OnPlatform simplification cause some issues - while used as a Resource (#17461, unable to unit test for now) - doesn't type convert. On nodes shouldn't be replaced by the Value, but an element node (<On Platform="..." Value="Red" /> should generate <Color x:Key="foo">Red</Color>. right now it only generated "Red" - fixes #17461 * disable failing test --------- Co-authored-by: Stephane Delcroix <stephane@delcroix.org>

jsuarezruiz added area-xaml XAML, CSS, Triggers, Behaviors area-perf Startup / Runtime performance labels Mar 28, 2022

StephaneDelcroix force-pushed the fix_5583 branch from fbe8492 to 81331cc Compare March 28, 2022 18:28

StephaneDelcroix changed the title ~~[X] Optimiz OnPlatform element syntax~~ [X] Optimise OnPlatform element syntax Mar 28, 2022

eerhardt reviewed Mar 28, 2022

View reviewed changes

StephaneDelcroix changed the title ~~[X] Optimise OnPlatform element syntax~~ [X] Optimize OnPlatform element syntax Mar 29, 2022

StephaneDelcroix force-pushed the fix_5583 branch from 81331cc to 0c0b89a Compare March 30, 2022 07:55

Redth added this to the 6.0.300 milestone May 5, 2022

PureWeen requested a review from eerhardt May 9, 2022 14:26

PureWeen assigned eerhardt May 9, 2022

Redth modified the milestones: 6.0.300, 6.0.300-servicing May 10, 2022

Redth modified the milestones: 6.0-servicing, .NET 7 Planning Aug 30, 2022

eerhardt removed their assignment Sep 26, 2022

samhouts modified the milestones: .NET 7 Planning, .NET 8 Planning Jan 26, 2023

StephaneDelcroix force-pushed the fix_5583 branch from 0c0b89a to e9b6a5a Compare May 31, 2023 07:53

StephaneDelcroix marked this pull request as ready for review June 13, 2023 13:53

StephaneDelcroix force-pushed the fix_5583 branch from 88fa47e to 18c22e9 Compare June 14, 2023 08:46

jonathanpeppers reviewed Jun 14, 2023

View reviewed changes

StephaneDelcroix and others added 4 commits June 19, 2023 14:06

[X] Optimize OnPlatform element syntax

720f410

- fixes #5583

Auto-format source code

03265bc

don't generate x:Name for removed OnPlatforms

fa30994

Update src/Controls/src/SourceGen/Controls.SourceGen.csproj

261f38b

Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>

fix string comparison

c191e4a

StephaneDelcroix force-pushed the fix_5583 branch from 2d2962c to c191e4a Compare June 19, 2023 12:07

PureWeen assigned StephaneDelcroix Jun 21, 2023

StephaneDelcroix mentioned this pull request Jul 25, 2023

Error when using Int32 as a resource for the parameter for <RoundRectangle CornerRadius=""> #16327

Closed

samhouts modified the milestones: .NET 8 Planning, Under Consideration Jul 26, 2023

PureWeen requested a review from jonathanpeppers August 7, 2023 14:51

jonathanpeppers approved these changes Aug 7, 2023

View reviewed changes

StephaneDelcroix merged commit 7c66539 into main Aug 9, 2023
33 checks passed

StephaneDelcroix deleted the fix_5583 branch August 9, 2023 07:55

samhouts mentioned this pull request Sep 28, 2023

[regression/8.0.0-rc.1.9171] Build error in .NET 8 RC1 - "XamlC error XFC0126: Resources in ResourceDictionary require a x:Key attribute" for resources that have a key #17461

Closed

samhouts added the reverted label Sep 29, 2023

jonathanpeppers mentioned this pull request Oct 9, 2023

[ios] Components podcastImage and epiosdeTitle don't exist in the current context microsoft/dotnet-podcasts#239

Closed

jonathanpeppers mentioned this pull request Oct 18, 2023

[net8.0] fix C# compiler error involving x:Name microsoft/dotnet-podcasts#242

Merged

github-actions bot locked and limited conversation to collaborators Dec 21, 2023

Eilon added t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) and removed area-perf Startup / Runtime performance labels May 10, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[X] Optimize OnPlatform element syntax #5611

[X] Optimize OnPlatform element syntax #5611

StephaneDelcroix commented Mar 28, 2022 •

edited by samhouts

StephaneDelcroix commented Mar 28, 2022

eerhardt Mar 28, 2022

StephaneDelcroix Mar 29, 2022 •

edited

eerhardt Mar 28, 2022

StephaneDelcroix Mar 29, 2022

StephaneDelcroix Jun 14, 2023

jonathanpeppers commented Jul 19, 2022

StephaneDelcroix commented Jul 20, 2022

github-actions bot commented May 31, 2023

StephaneDelcroix commented Jun 13, 2023

StephaneDelcroix commented Aug 8, 2023

azure-pipelines bot commented Aug 8, 2023

[X] Optimize OnPlatform element syntax #5611

[X] Optimize OnPlatform element syntax #5611

Conversation

StephaneDelcroix commented Mar 28, 2022 • edited by samhouts

Description of Change

StephaneDelcroix commented Mar 28, 2022

eerhardt Mar 28, 2022

Choose a reason for hiding this comment

StephaneDelcroix Mar 29, 2022 • edited

Choose a reason for hiding this comment

eerhardt Mar 28, 2022

Choose a reason for hiding this comment

StephaneDelcroix Mar 29, 2022

Choose a reason for hiding this comment

StephaneDelcroix Jun 14, 2023

Choose a reason for hiding this comment

jonathanpeppers commented Jul 19, 2022

StephaneDelcroix commented Jul 20, 2022

github-actions bot commented May 31, 2023

StephaneDelcroix commented Jun 13, 2023

StephaneDelcroix commented Aug 8, 2023

azure-pipelines bot commented Aug 8, 2023

StephaneDelcroix commented Mar 28, 2022 •

edited by samhouts

StephaneDelcroix Mar 29, 2022 •

edited