Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PackageValidationBaselineVersion #10116

Conversation

surayya-MS
Copy link
Member

@surayya-MS surayya-MS commented May 7, 2024

Part of #9914 "Create and merge PR including public API baseline package version change"

@surayya-MS surayya-MS requested a review from a team as a code owner May 7, 2024 15:07
@rainersigwald
Copy link
Member

This looks syntactically good but we can't merge it until that package is pushed to NuGet.org and the release is done.

@surayya-MS
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rainersigwald
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@@ -27,6 +27,11 @@
<NoWarn>$(NoWarn);NU5104</NoWarn>
</PropertyGroup>

<PropertyGroup>
<ApiCompatPreserveUnnecessarySuppressions>true</ApiCompatPreserveUnnecessarySuppressions>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not ideal, but the check is currently failing in a weird way where it is complaining about the comments that we have on the xml files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants