-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update PackageValidationBaselineVersion #10116
Closed
surayya-MS
wants to merge
3
commits into
dotnet:main
from
surayya-MS:update-PackageValidationBaselineVersion
Closed
Update PackageValidationBaselineVersion #10116
surayya-MS
wants to merge
3
commits into
dotnet:main
from
surayya-MS:update-PackageValidationBaselineVersion
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This looks syntactically good but we can't merge it until that package is pushed to NuGet.org and the release is done. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
maridematte
reviewed
May 29, 2024
@@ -27,6 +27,11 @@ | |||
<NoWarn>$(NoWarn);NU5104</NoWarn> | |||
</PropertyGroup> | |||
|
|||
<PropertyGroup> | |||
<ApiCompatPreserveUnnecessarySuppressions>true</ApiCompatPreserveUnnecessarySuppressions> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not ideal, but the check is currently failing in a weird way where it is complaining about the comments that we have on the xml files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9914 "Create and merge PR including public API baseline package version change"