Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better diagnostic logging in RAR when marking CopyLocal=false #1485

Open
KirillOsenkov opened this issue Dec 15, 2016 · 0 comments
Open

Better diagnostic logging in RAR when marking CopyLocal=false #1485

KirillOsenkov opened this issue Dec 15, 2016 · 0 comments
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. Task: Resolve Assembly References (RAR) triaged User Experience

Comments

@KirillOsenkov
Copy link
Member

Sometimes it is very difficult to understand why some transitive dependencies are copied to the output directory while others aren't.

It would greatly help to improve logging in this code:
https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeTasks/AssemblyDependency/Reference.cs#L1226-L1247

Specifically, we already list all source items in the log:
https://github.com/Microsoft/msbuild/blob/xplat/src/XMakeTasks/AssemblyDependency/ResolveAssemblyReference.cs#L1645
It would be nice to also print their Private metadata if present.

This way we can know which one specified their Private=false and let to exclusion. Otherwise we have to double-check in the log elsewhere what the metadata was. It's possible but hard to use.
@jeffkl jeffkl added enhancement help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. labels Dec 15, 2016
@Sarabeth-Jaffe-Microsoft Sarabeth-Jaffe-Microsoft added help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. and removed help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. enhancement labels Apr 7, 2017
@KirillOsenkov KirillOsenkov added Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging labels Apr 9, 2020
@AR-May AR-May added the triaged label Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area: Debuggability Issues impacting the diagnosability of builds, including logging and clearer error messages. Area: Logging help wanted Issues that the core team doesn't plan to work on, but would accept a PR for. Comment to claim. Task: Resolve Assembly References (RAR) triaged User Experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@KirillOsenkov @cdmihai @rainersigwald @jeffkl @Sarabeth-Jaffe-Microsoft @AR-May