-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visual Studio doesn't fail when the warning MSB3247 is added to WarningsAsErrors #6473
Comments
Unable to repro in This was likely fixed with #5957. Is it possible for you to upgrade your version of VS? |
@MattBussing If it properly fails in the output/command line then it's fixed in terms of MSBuild. Still seeing it as a warning in that window is project-system I believe? /cc: @jjmew |
Closing in the meantime. Feel free to open an issue in dotnet/project-system |
Yeah sounds good! I will open a ticket there. Thank you! |
Issue Description
If I set several MSBuild warnings to errors via MSBuildWarningsAsErrors and WarningsAsErrors and build with Visual Studio, VS will successfully build and output the warnings, that should be errors, as normal warnings. Here are the settings. You can get the project to reproduce the error at https://github.com/MattBussing/vs-issue-example.
Steps to Reproduce
Expected Behavior
The build to fail in VS and output MSB3247 as an error.
Actual Behavior
VS
Here it doesn't fail. It just warns about the issue.
Rider
Rider actually fails.
Versions & Configurations
VS
Microsoft Visual Studio Professional 2019
Version 16.9.4
MSBuild 16.9.0.16703
Rider
JetBrains Rider 2021.1.2
Build #RD-211.7142.19, built on April 22, 2021
Runtime version: 11.0.10+9-b1341.41 amd64
VM: Dynamic Code Evolution 64-Bit Server VM by JetBrains s.r.o.
Windows 10 10.0
.NET Framework 4.0.30319.42000
The text was updated successfully, but these errors were encountered: