Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automated] Merge branch 'vs17.2' => 'main' #8293

Merged
merged 16 commits into from
Feb 8, 2023

Conversation

dotnet-maestro-bot
Copy link
Contributor

I detected changes in the vs17.2 branch which have not been merged yet to main. I'm a robot and am configured to help you automatically keep main up to date, so I've opened this PR.

This PR merges commits made on vs17.2 by the following committers:

Instructions for merging from UI

This PR will not be auto-merged. When pull request checks pass, complete this PR by creating a merge commit, not a squash or rebase commit.

merge button instructions

If this repo does not allow creating merge commits from the GitHub UI, use command line instructions.

Instructions for merging via command line

Run these commands to merge this pull request from the command line.

git fetch
git checkout vs17.2
git pull --ff-only
git checkout main
git pull --ff-only
git merge --no-ff vs17.2

# If there are merge conflicts, resolve them and then run git merge --continue to complete the merge
# Pushing the changes to the PR branch will re-trigger PR validation.
git push https://github.com/dotnet-maestro-bot/msbuild HEAD:merge/vs17.2-to-main
or if you are using SSH
git push git@github.com:dotnet-maestro-bot/msbuild HEAD:merge/vs17.2-to-main

After PR checks are complete push the branch

git push

Instructions for resolving conflicts

⚠️ If there are merge conflicts, you will need to resolve them manually before merging. You can do this using GitHub or using the command line.

Instructions for updating this pull request

Contributors to this repo have permission update this pull request by pushing to the branch 'merge/vs17.2-to-main'. This can be done to resolve conflicts or make other changes to this pull request before it is merged.

git checkout -b merge/vs17.2-to-main main
git pull https://github.com/dotnet-maestro-bot/msbuild merge/vs17.2-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push https://github.com/dotnet-maestro-bot/msbuild HEAD:merge/vs17.2-to-main
or if you are using SSH
git checkout -b merge/vs17.2-to-main main
git pull git@github.com:dotnet-maestro-bot/msbuild merge/vs17.2-to-main
(make changes)
git commit -m "Updated PR with my changes"
git push git@github.com:dotnet-maestro-bot/msbuild HEAD:merge/vs17.2-to-main

Contact .NET Core Engineering if you have questions or issues.
Also, if this PR was generated incorrectly, help us fix it. See https://github.com/dotnet/arcade/blob/master/scripts/GitHubMergeBranches.ps1.

dotnet-maestro bot and others added 16 commits March 3, 2022 14:44
* Update dependencies from https://github.com/dotnet/arcade build 20220105.3

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22055.3

* Update dependencies from https://github.com/dotnet/arcade build 20220204.7

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22104.7

* Update dependencies from https://github.com/dotnet/arcade build 20220222.5

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22122.5

* Update dependencies from https://github.com/dotnet/arcade build 20220223.4

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.21505.11 -> To Version 5.0.0-beta.22123.4

* update mac version

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Forgind <Forgind@users.noreply.github.com>
…309.5

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.22123.4 -> To Version 5.0.0-beta.22159.5
…526.2

Microsoft.DotNet.Arcade.Sdk
 From Version 5.0.0-beta.22123.4 -> To Version 5.0.0-beta.22276.2
* Avoid AssemblyName.KeyPair on .NET

It throws on .NET 6 and wasn't helpful before anyway:

(from https://docs.microsoft.com/en-us/dotnet/api/system.reflection.assemblyname.keypair?view=net-5.0#remarks):

> When the runtime loads an assembly, it does not set the KeyPair property. The getter for the property is only useful if the user set the property before using the AssemblyName object to create a dynamic assembly, and subsequently wants to retrieve the key pair.

Also disable some parts of the official build that are currently broken, but don't affect building the bits that go into the .NET SDK.

Co-authored-by: Forgind <Forgind@users.noreply.github.com>
…ision-16.11

Fixes dotnet/sdk#25698 for 16.11, merging forward (+ infrastructure updates).
* Update the runsettings configuration creation for opt-prof v2 pipeline.

* Add opt-prof v2 pipeline configuration yml.
The win2016 images aren't live any more.
…16.11-to-vs17.0-2

Backport opt-prof v2 vs17.0 

- [vs16.11] Update dependencies from dotnet/arcade (dotnet#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (dotnet#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request dotnet#7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (dotnet#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request dotnet#8210 from rainersigwald/exp/16.11-build

### Testing
CI, Opt-prof CI
…17.0-to-vs17.2

Backport opt-prof v2 vs17.2

Brings the following changes from the 17.0 branch into 17.2:
- [vs16.11] Update dependencies from dotnet/arcade (dotnet#7332)
- Update dependencies from https://github.com/dotnet/arcade build 20220309.5
- Update dependencies from https://github.com/dotnet/arcade build 20220526.2
- Bump CLI version to match global.json
- Bump NuGet version to match
- Avoid AssemblyName.KeyPair on .NET (dotnet#7660)
- Merge remote-tracking branch 'upstream/vs16.9' into backport-keypair-elision-16.11
- Merge pull request dotnet#7663 from rainersigwald/backport-keypair-elision-16.11
- Configure OptProf v2 pipeline 16.11 (dotnet#8189)
- Updating 'Microsoft.DotNet.Arcade.Sdk': '5.0.0-beta.22276.2' => '5.0.0-beta.22526.12'
- Move BAR publish to windows-latest
- Merge pull request dotnet#8210 from rainersigwald/exp/16.11-build
- Merge remote-tracking branch 'upstream/vs16.11' into exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2
- Merge pull request dotnet#8260 from dotnet/exp/AR-May/opt-prof-fix-vs16.11-to-vs17.0-2

### Testing
CI
@Forgind
Copy link
Member

Forgind commented Jan 18, 2023

This should come through #8304 and follow-up PRs. We should close it, but I'm converting it to a draft for now so it doesn't reopen itself. (I'm not 100% sure if it would anyway.)

@Forgind Forgind marked this pull request as draft January 18, 2023 00:19
@JaynieBai JaynieBai merged commit bee335c into dotnet:main Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants