Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 17.4 from 17.2 #8445

Merged
merged 4 commits into from
Feb 14, 2023
Merged

Update 17.4 from 17.2 #8445

merged 4 commits into from
Feb 14, 2023

Commits on Feb 7, 2023

  1. Fix temp file filtering in FileTracker (dotnet#8352) 

    (Copied from dotnet#8351)

Fixes AB#1678521

Context
dotnet#8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

Changes Made
Reverted the change. Enabled relevant unit tests.

Testing
Existing unit tests and a C++ end-to-end repro.

Notes
The rest of FileTracker tests cannot be enabled without significant work (related to dotnet#649).
    @Forgind
    Forgind committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    2fdde65 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'vs17.0' of https://github.com/dotnet/msbuild into vs17.2

    @Forgind
    Forgind committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    6faa1d5 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Merge pull request dotnet#8419 from Forgind/fix-temp-file-filtering-17.2 

    Fixes AB#1678521

Context
dotnet#8049 broke the temp filtering logic by using the MSBuild-specific temp path instead of the true base temp path. This manifests as an overbuild of some C++ projects.

Changes Made
Reverted the change. Enabled relevant unit tests.

Testing
Existing unit tests and a C++ end-to-end repro.

Notes
The rest of FileTracker tests cannot be enabled without significant work (related to dotnet#649).
    @Forgind
    Forgind committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    872ddd9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'vs17.2' of https://github.com/dotnet/msbuild into updat… 

    …e-17.4-from-17.2
    @Forgind
    Forgind committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    88e6887 View commit details
    Browse the repository at this point in the history