Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails if nbgv is already installed #4

Closed
AArnott opened this issue Aug 18, 2019 · 0 comments
Closed

Action fails if nbgv is already installed #4

AArnott opened this issue Aug 18, 2019 · 0 comments
Assignees

Comments

@AArnott
Copy link
Collaborator

AArnott commented Aug 18, 2019

The dotnet tool install step returns a non-zero exit code if the tool is already installed, so it fails on repeated runs or if run after dotnet tool install already installed nbgv.

We should make this more resilient.

Also, we should consider not installing the tool globally. This is useful if the agent the action runs on is shared or reused across runs. Is that possible? In Azure Pipelines there are "private agents" which make it important for tasks to not change machine-wide state. Is such the case here?

@AArnott AArnott self-assigned this Aug 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant