Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional TFM to reduce dependencies #740

Closed
thompson-tomo opened this issue Apr 16, 2024 · 3 comments · Fixed by #741
Closed

Add additional TFM to reduce dependencies #740

thompson-tomo opened this issue Apr 16, 2024 · 3 comments · Fixed by #741
Assignees

Comments

@thompson-tomo
Copy link

thompson-tomo commented Apr 16, 2024

Is your feature request related to a problem? Please describe.

I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like

I want the package to not have a dependencies on packages which can be provided by the framework (net 6/net core 3) ie System.IO.Pipelines

Describe alternatives you've considered

Accept the additional dependency

Additional context

No response

@AArnott AArnott self-assigned this Apr 17, 2024
@AArnott
Copy link
Collaborator

AArnott commented Apr 17, 2024

Although https://apisof.net/catalog/f7ac641b77d48667e31915ca6b9b07ae suggests that System.IO.Pipelines is included in .NET 6, it doesn't appear to be true. And the package for it includes assemblies for net6.0, which wouldn't be the case if it was included in the runtime. So your example in particular might have been a bad one. But System.Runtime.CompilerServices.Unsafe is a dependency we can drop by adding a net6.0 target to the library. Would that be worthwhile to you?

@thompson-tomo
Copy link
Author

@AArnott i just took a look at the v6 version of the package doesn't in fact include assemblies (https://www.nuget.org/packages/System.IO.Pipelines/6.0.3#dependencies-body-tab)

@AArnott
Copy link
Collaborator

AArnott commented Apr 18, 2024

The link shows dependencies. Not content of the package itself. You have to download the package and look at its lib folder:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants