Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Perf] Alpine/x64: 2 Regressions on 3/27/2023 6:14:52 PM #14505

Open
performanceautofiler bot opened this issue Mar 28, 2023 · 3 comments
Open

[Perf] Alpine/x64: 2 Regressions on 3/27/2023 6:14:52 PM #14505

performanceautofiler bot opened this issue Mar 28, 2023 · 3 comments

Comments

@performanceautofiler
Copy link

performanceautofiler bot commented Mar 28, 2023

Run Information

Name Value
Architecture x64
OS alpine 3.15
Queue TigerAlpine
Baseline 9b38f2ab7440b551e294ff43eea20ef8866c931a
Compare ed3721b092e395ac3576c2d93f4134650a44dc08
Diff Diff
Configs CompilationMode:tiered, RunKind:micro

Regressions in Exceptions.Handling

Benchmark Baseline Test Test/Base Test Quality Edge Detector Baseline IR Compare IR IR Ratio Baseline ETL Compare ETL
MultipleNestedTryCatch_LastCatches - Duration of single invocation 5.83 μs 6.67 μs 1.14 0.54 False
CatchAndThrowOtherDeep - Duration of single invocation 228.69 μs 250.64 μs 1.10 0.02 False

graph
Test Report

Repro

General Docs link: https://github.com/dotnet/performance/blob/main/docs/benchmarking-workflow-dotnet-runtime.md

Payloads

Baseline
Compare

git clone https://github.com/dotnet/performance.git
py .\performance\scripts\benchmarks_ci.py -f net8.0 --filter 'Exceptions.Handling*'

Payloads

Baseline
Compare

Histogram

Exceptions.Handling.MultipleNestedTryCatch_LastCatches(kind: Hardware)


Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 6.669411241634629 > 6.156614949664384.
IsChangePoint: Marked as a change because one of 3/27/2023 3:21:55 PM, 3/28/2023 8:13:28 AM falls between 3/19/2023 2:30:51 PM and 3/28/2023 8:13:28 AM.
IsRegressionStdDev: Marked as regression because -9.809142808084488 (T) = (0 -6628.625443231225) / Math.Sqrt((93094.10677062829 / (55)) + (4363.167384241287 / (4))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (55) + (4) - 2, .025) and -0.0846836179343812 = (6111.114184479395 - 6628.625443231225) / 6111.114184479395 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

```#### Exceptions.Handling.CatchAndThrowOtherDeep(kind: Hardware)

```log

Description of detection logic

IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsRegressionBase: Marked as regression because the compare was 5% greater than the baseline, and the value was not too small.
IsRegressionChecked: Marked as regression because the three check build points were 0.05 greater than the baseline.
IsRegressionWindowed: Marked as regression because 250.6371069119458 > 239.4769215578046.
IsChangePoint: Marked as a change because one of 3/27/2023 3:21:55 PM, 3/28/2023 8:13:28 AM falls between 3/19/2023 2:30:51 PM and 3/28/2023 8:13:28 AM.
IsRegressionStdDev: Marked as regression because -4.226423667902842 (T) = (0 -264118.623097083) / Math.Sqrt((16578288.241222126 / (55)) + (237319016.0492749 / (4))) is less than -2.0024654592901125 = MathNet.Numerics.Distributions.StudentT.InvCDF(0, 1, (55) + (4) - 2, .025) and -0.14099156505454602 = (231481.66137797575 - 264118.623097083) / 231481.66137797575 is less than -0.05.
IsImprovementBase: Marked as not an improvement because the compare was not 5% less than the baseline, or the value was too small.
IsChangeEdgeDetector: Marked not as a regression because Edge Detector said so.

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

@EgorBo
Copy link
Member

EgorBo commented Mar 28, 2023

@tannergooding it looks to be dotnet/runtime#83784 - is it expected to slow down exception handling?

@EgorBo
Copy link
Member

EgorBo commented Mar 28, 2023

Same here #14497

@AndyAyersMS
Copy link
Member

Still slower as of 8/23, but not as bad as it was in March.

newplot - 2023-08-24T094132 602

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants