Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rx.Net: Add Silverlight 5 support for portable library #32

Closed
mattpodwysocki opened this issue Oct 13, 2014 · 2 comments
Closed

Rx.Net: Add Silverlight 5 support for portable library #32

mattpodwysocki opened this issue Oct 13, 2014 · 2 comments

Comments

@mattpodwysocki
Copy link
Contributor

Copied from https://rx.codeplex.com/workitem/34

Silverlight 5 should support all (or almost all) of the portable library API, please add it to the list of supported platforms for the portable library.

By not supporting Silverlight 5 you prevent everyone else from building portable libraries compatible with SL5 from using Rx. If you wan't async support just utilize the microsoft.bcl.async package since it add async support

@mattpodwysocki
Copy link
Contributor Author

danneesset wrote Apr 13, 2013 at 3:48 PM

I've looked a bit at the code and I hope t can be solved quite easily by following the following steps.
But it would require a new version of all platforms.

1; We need 2 different portable libraries, the current one plus one which is "more portable" (target platforms where IObservable) does not exist. This second portable library would then include the implementation of the IObservable interfaces.
BTW: I think it would be a good idea to utilize the Microsoft.Bcl.Async package in order to add task and async support to nearly all platforms.

2; Add TypeForwardedToAttribute's in order to forward the IObservable interfaces to all builds which does not define the NO_RXINTERFACES (like the current portable library). In this way allassemblies compiled against the "more portable" will work with the current portable assembly as well as all current platforms assemblies.

You can then choose any of the libraries to compile against with the new portable library allowing us to build portable libraries which target more platforms.

@rozele
Copy link

rozele commented Apr 21, 2015

This issue has already been resolved as of 2.2.5. This package was shipped with a build targeted to portable-net40+sl5+win8+wp8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants